set id

emberjs · Nov 20, 2019 · 683ac50 · 683ac50
1 parent cee9f87
commit 683ac50
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 0 deletions.
diff --git a/packages/-ember-data/tests/unit/model-test.js b/packages/-ember-data/tests/unit/model-test.js
@@ -375,6 +375,27 @@ module('unit/model - Model', function(hooks) {
       assert.equal(person.get('id'), 'john', 'new id should be correctly set.');
     });
 
+    test('ID mutation (complicated) igor', async function(assert) {
+      let idChange = 0;
+      const OddPerson = Model.extend({
+        name: DSattr('string'),
+        idComputed: computed('id', function() {}),
+        idDidChange: observer('id', () => idChange++),
+      });
+      this.owner.register('model:odd-person', OddPerson);
+
+      let person = store.createRecord('odd-person');
+      person.get('idComputed');
+      assert.equal(idChange, 0);
+
+      assert.equal(person.get('id'), null, 'initial created model id should be null');
+      assert.equal(idChange, 0);
+      person.set('id', 'john');
+      let recordData = recordDataFor(person);
+      assert.equal(recordData.getResourceIdentifier().id, 'john', 'new id should be correctly set.');
+      assert.equal(recordData.id, 'john', 'new id should be correctly set.');
+    });
+
     test('an ID of 0 is allowed', async function(assert) {
       store.push({
         data: {

diff --git a/packages/record-data/addon/-private/record-data.ts b/packages/record-data/addon/-private/record-data.ts
@@ -430,6 +430,13 @@ export default class RecordDataDefault implements RelationshipRecordData {
     }
   }
 
+  // internal set coming from the model
+  _setId(id: string) {
+    if (this.id !== id) {
+      this.id = id;
+    }
+  }
+
   getAttr(key: string): string {
     if (key in this._attributes) {
       return this._attributes[key];

diff --git a/packages/store/addon/-private/system/model/internal-model.ts b/packages/store/addon/-private/system/model/internal-model.ts
@@ -1359,6 +1359,10 @@ export default class InternalModel {
 
     if (didChange && id !== null) {
       this.store.setRecordId(this.modelName, id, this.clientId);
+      // internal set of ID to get it to RecordData from DS.Model
+      if (this._recordData.__setId) {
+        this._recordData.__setId(id);
+      }
     }
 
     if (didChange && this.hasRecord) {

diff --git a/packages/store/addon/-private/ts-interfaces/record-data.ts b/packages/store/addon/-private/ts-interfaces/record-data.ts
@@ -61,4 +61,7 @@ export default interface RecordData {
   isDeletionCommitted?(): boolean;
 
   setIsDeleted?(isDeleted: boolean): void;
+
+  // Private and experimental
+  __setId?(id: string): void;
 }