-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dont pin eslint-parser, allow eslint 9 #95
Conversation
No idea why that no-get test is failing 😢 |
I tried a few things to get that Decided to make sure the So I don't think the updates in this PR are causing the rule failure - something somewhere else has changed. |
Thanks for the analysis! Any chance you'd be able to fix whatever is going on there? |
Gotta pin down the root cause & try and get that empty PR passing. Given that the failing step clones Cloning a project for tests isn't very deterministic, wondering if we should pin it to a commit or version anyway. Something to think about after figuring out the issue |
Some progress over in #97 - I've left some comments there. |
This PR has the fix to get those tests passing now, needed to import the lockfile. Should be good to go. |
f34bfa4
to
629219f
Compare
Thank you!! |
I think
@babel/eslint-parser
might have been mistakenly pinned in this PR #41 to an explicit version instead of using^
This older version
7.23.10
doesn't allow eslint v9, whereas later minor versions like7.25.1
do