Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error on custom-elements #109

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Don't error on custom-elements #109

merged 2 commits into from
Nov 22, 2024

Conversation

NullVoxPopuli
Copy link
Member

Closes #29
by making it not a problem anymore.

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Nov 22, 2024
@NullVoxPopuli NullVoxPopuli self-assigned this Nov 22, 2024
@patricklx
Copy link
Collaborator

makes sense! since custom elements are required to have a - and by having that, they really cannot reference a variable

@evoactivity @bertdeblock
fix typo
a1de425 
Co-authored-by: Bert De Block <deblockbert@gmail.com>
@NullVoxPopuli NullVoxPopuli merged commit a7f8e7e into main Nov 22, 2024
9 of 10 checks passed
@NullVoxPopuli NullVoxPopuli deleted the dont-error-on-custom-elements branch November 22, 2024 15:40
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertdeblock bertdeblock bertdeblock left review comments

@evoactivity evoactivity evoactivity approved these changes

@patricklx patricklx patricklx approved these changes

Assignees

@NullVoxPopuli NullVoxPopuli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document what to do with custom-elements and other not-defined HTML tags (no-undef)
4 participants
@NullVoxPopuli @patricklx @evoactivity @bertdeblock