Skip to content

Commit

Permalink
Merge pull request #125 from ember-tooling/add-fix-checking-to-ci
Browse files Browse the repository at this point in the history
Add --fix checking
  • Loading branch information
NullVoxPopuli authored Jan 28, 2025
2 parents 87cbeca + e9f5d81 commit 0cc0651
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 10 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ jobs:
mv "$tmp" package.json
- run: pnpm install --no-frozen-lockfile
- run: pnpm test
- run: pnpm --filter '*' test
- run: pnpm --filter '*' test:check
- run: pnpm --filter '*' test:fix



test_eslint-plugin-ember:
Expand Down
5 changes: 3 additions & 2 deletions test-projects/configs/flat-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"name": "@test-project/configs-flat-js",
"private": true,
"scripts": {
"test:notes": "This isn't just 'eslint .' because we aren't in a type=module package",
"test": "pnpm eslint:with-config .",
"notes": "This isn't just 'eslint .' because we aren't in a type=module package",
"test:check": "pnpm eslint:with-config .",
"test:fix": "pnpm eslint:with-config . --fix",
"eslint:with-config": "ESLINT_USE_FLAT_CONFIG=true eslint --config ./eslint.config.mjs --max-warnings=0",
"eslint:debug-file": "pnpm eslint:with-config --print-config"
},
Expand Down
5 changes: 3 additions & 2 deletions test-projects/configs/flat-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
"private": true,
"version": "0.0.0",
"scripts": {
"test:notes": "This isn't just 'eslint .' because we aren't in a type=module package",
"test": "pnpm eslint:with-config .",
"notes": "This isn't just 'eslint .' because we aren't in a type=module package",
"test:check": "pnpm eslint:with-config .",
"test:fix": "pnpm eslint:with-config . --fix",
"eslint:with-config": "ESLINT_USE_FLAT_CONFIG=true eslint --config ./eslint.config.mjs --max-warnings=0",
"eslint:debug-file": "pnpm eslint:with-config --print-config"
},
Expand Down
7 changes: 4 additions & 3 deletions test-projects/gjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
"name": "@test-project/gjs",
"private": true,
"scripts": {
"test": "pnpm run /test:.*/",
"test:correct-handle-syntax-error": "eslint . | grep -q '26:15 error Parsing error: × Unexpected eof'",
"test:only-one-error": "eslint --format compact . | egrep '^[0-9]+ problem[s]*' | wc -l | grep -q 1"
"test:check": "pnpm run /test:check:.*/",
"test:check:correct-handle-syntax-error": "eslint . | grep -q '26:15 error Parsing error: × Unexpected eof'",
"test:check:only-one-error": "eslint --format compact . | egrep '^[0-9]+ problem[s]*' | wc -l | grep -q 1",
"test:fix": "eslint --fix --format compact . | egrep '^[0-9]+ problem[s]*' | wc -l | grep -q 1"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.21.0",
Expand Down
3 changes: 2 additions & 1 deletion test-projects/gts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"name": "@test-project/gts",
"private": true,
"scripts": {
"test": "eslint . --max-warnings=0",
"test:check": "eslint . --max-warnings=0",
"test:fix": "eslint . --fix --max-warnings=0",
"types": "tsc --noEmit"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"name": "@test-project/rules-padding-line-between-statements",
"private": true,
"scripts": {
"test": "eslint . --max-warnings=0"
"test:check": "eslint . --max-warnings=0",
"test:fix": "eslint . --fix --max-warnings=0"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.21.0",
Expand Down

0 comments on commit 0cc0651

Please sign in to comment.