Simplifies the "All we want to do..." portion #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Routes & Templates page, in the An Index Route section, the paragraphs starting at "All we want to do..." presents too much ancillary data. This change simplifies it to focus on just the beforeModel() hook and the replaceWith() function.
jenweber
reviewed
Nov 20, 2018
jenweber
requested changes
Nov 20, 2018
Co-Authored-By: zachgarwood <iam@zachgarwood.com>
|
@jenweber I think your suggestion was succinct and provides exactly as much context as needed, namely that hooks are called automatically at certain events. |
|
Cool, thanks! Merged. |
jenweber
approved these changes
Nov 29, 2018
jenweber
added a commit
that referenced
this pull request
Nov 29, 2018
|
Note to self, this has been added to the 3.6 staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Routes & Templates page, in the An Index Route section, the
paragraphs starting at "All we want to do..." present too much
ancillary information. This change simplifies it to focus on just the
beforeModel() hook and the replaceWith() function.
This addresses one of the "tiny tutorial fixes" @jenweber listed
in #245.