Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.6.0 with array helper #212

Closed
wants to merge 1 commit into from
Closed

v3.6.0 with array helper #212

wants to merge 1 commit into from

Conversation

locks
Copy link
Contributor

@locks locks commented Oct 15, 2018

No description provided.

@locks locks added the on hold label Oct 15, 2018
mansona
mansona requested changes Oct 15, 2018
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@locks has already added the "on hold" label but I wanted to add a "rejected" review to make clear that we don't want to merge this yet 👍

@jenweber
Copy link
Contributor

@locks @mansona we need a plan to make sure that the work done on 3.5 in the meantime doesn't get dropped. Can you look into exactly how we should do that? Maybe some git diff magic?

@locks locks mentioned this pull request Nov 2, 2018
Closed
@jenweber jenweber mentioned this pull request Nov 23, 2018
Closed
5 tasks
@jenweber jenweber changed the base branch from master to v3.6-staging November 23, 2018 19:29
@jenweber jenweber changed the base branch from v3.6-staging to master November 23, 2018 19:31
@jenweber
Copy link
Contributor

I tried changing the base to the v3.6-staging branch and GitHub didn't like it. I will merge/rebase and then open a new PR to see if that's easier to review.

@jenweber
Copy link
Contributor

Merged into the 3.6 staging branch via #287

@jenweber jenweber closed this Nov 23, 2018
@locks locks deleted the array-helper branch January 12, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona requested changes

Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @jenweber @mansona