Avoid triggering a watch on the addon root #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hey that makes a lot of sense! This looks good, lets merge and get it out there 😄 |
|
👍 I'll let CI do its thing and then get this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #106. The underlying cause looks to be nodejs/node#15683, so anyone on APFS who's not using watchman is likely to run into this.
The problem in our specific case is that we're triggering a watch on the root of the repo in question, which means it includes all of
tmpandnode_modules, both of which are potentially pretty big.@pzuraq I know you're on your way out, but if you have a chance to take a peek, I'll cut a bugfix release if the changes look good to you.