Addressed failing CI. Added Ember 4.8 LTS to test matrix. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request patches #388.
#388 passed CI on December 16 (while in review status), but failed CI on the 17th (after merge). It turned out,
ember-qunitreleased a minor version overnight and introduced a peer dependency requirement (@glimmer/interfaces@^0.84.2and@glimmer/reference@^0.84.2).To unblock work, I'll temporarily pin the version of
ember-qunittov6.0.0. (Yarn resolutions did not work, possibly because this project is not a yarn workspace yet.)In the 3rd commit, I took @bertdeblock's suggestion and added Ember 4.8 LTS to the test matrix.
References