Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest v2 addon tooling (v1.5.0) #386

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Update to latest v2 addon tooling (v1.5.0) #386

merged 1 commit into from
Mar 17, 2022

Conversation

SergeAstapov
Copy link
Contributor

This is follow up to #384 but updates all @embroider/* packages to v1.1.0

@SergeAstapov
Copy link
Contributor Author

@ef4 would you mind to approve CI?

@ef4
Copy link
Contributor

ef4 commented Feb 9, 2022

Done

@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented Feb 10, 2022 •
edited
Loading

@ef4 sorry for churn, fixed setup (missed same dependency in /test-app), tests should be green now per fork CI

@SergeAstapov SergeAstapov changed the title Update to latest v2 addon tooling (v1.1.0) Update to latest v2 addon tooling (v1.2.0) Feb 23, 2022
@SergeAstapov
Copy link
Contributor Author

@ef4 do you mind to land this so new apps use v1 of all @embroider/* packages by default so no pre-v1 hanging around?

@SergeAstapov SergeAstapov changed the title Update to latest v2 addon tooling (v1.2.0) Update to latest v2 addon tooling (v1.5.0) Mar 17, 2022
@rwjblue rwjblue merged commit 225595a into ember-cli:master Mar 17, 2022
@SergeAstapov SergeAstapov deleted the update-embroider branch March 17, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeAstapov @ef4 @rwjblue