Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli-shims error #33

Closed
marcoow opened this issue Mar 1, 2016 · 8 comments
Closed

ember-cli-shims error #33

marcoow opened this issue Mar 1, 2016 · 8 comments

Comments

@marcoow
Copy link

marcoow commented Mar 1, 2016

I'm seeing the ember-cli-shims-versions-prior-to-0.1.0 error when running Ember Simple Auth's blueprint tests with Ember/Ember Data/Ember CLI 2.4.x:

1) Acceptance: ember generate and destroy authenticator generates an OAuth 2.0 authenticator:
     Error: the object {
  "errorLog": [
    {
      "isSilentError": true
      "message": "Using a version of ember-cli-shims prior to 0.1.0 will cause errors while loading Ember Data 2.3.0-beta.3+. Please update ember-cli-shims from undefined to 0.1.0."
      "name": "SilentError"
      "suppressedStacktrace": true
    }
  ]
  "exitCode": 1
  "inputStream": []
  "outputStream": []
  "statusCode": 1
} was thrown, throw an Error :)

I'm not sure whether that's a bug in this library or something wrong with the way it's being used in ESA but I was under the impression that bower is skipped in the temp project that the blueprints are run in anyway so that it shouldn't have ember-cli-shims at all?

This pull request has the code that updates Ember CLI et al in ESA with the failing tests: mainmatter/ember-simple-auth#918

@trabus
Copy link
Contributor

trabus commented Mar 1, 2016

@marcoow It seems you're running an older version, and you're missing your test package fixtures, I'd recommend upgrading to 0.9.0 and try running the default blueprint again ember g ember-cli-blueprint-test-helpers

I missed that you had upgraded and added in the PR you linked. I'll look into this a little more and see what I can find.

@trabus
Copy link
Contributor

trabus commented Mar 2, 2016

@marcoow some investigation brought me to this line in ember-data: https://github.com/emberjs/data/blob/f261ca8902219244994e79ba4785607d845d53ce/index.js#L33

and running the node test with EMBER_DATA_SKIP_VERSION_CHECKING_DO_NOT_USE_THIS_ENV_VARIABLE=true npm run nodetest
makes the error go away, and fixes all the tests except for the throws tests:

  Acceptance: ember generate and destroy authenticator
     generates a torii authenticator (669ms)
     generates an OAuth 2.0 authenticator (220ms)
     generates a devise authenticator (187ms)
     generates a generic authenticator (171ms)
Authenticators cannot extend from themself. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".
    1) throws when the authenticator is specified as its own base class
The authenticator base class "unknown" is unknown. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".
    2) throws when an unknown base class is specified

  Acceptance: ember generate and destroy authorizer
     generates an OAuth 2.0 authorizer (185ms)
     generates a devise authorizer (207ms)
     generates a generic authorizer (178ms)
Authorizers cannot extend from themself. Remove the --base-class option or specify one of "oauth2" or "devise".
    3) throws when the authorizer is specified as its own base class
The authorizer base class "unknown" is unknown. Remove the --base-class option or specify one of "oauth2" or "devise".
    4) throws when an unknown base class is specified

For the throws issue, it seems that this change: ember-cli/ember-cli@d79f810#diff-046dd933d1aae8e9131812190820a4c6R81
broke the assertThrows check, because we are expecting the error rather than the whole results object:
https://github.com/ember-cli/ember-cli-blueprint-test-helpers/blob/master/lib/helpers/blueprint-helper.js#L245

I will file an issue for the broken assertThrows functionality and try and get a new release cut soon.

@rwjblue
Copy link
Member

rwjblue commented Mar 2, 2016

damn, and I thought EMBER_DATA_SKIP_VERSION_CHECKING_DO_NOT_USE_THIS_ENV_VARIABLE was long enough ;P

@trabus
Copy link
Contributor

trabus commented Mar 2, 2016

I'm probably not going to file the 'throws' issue tonight, I'm laying in bed sick, so I'll probably try and pick it back up tomorrow. Something is definitely funky with it though, We may need to revisit how we're doing it here.

@marcoow
Copy link
Author

marcoow commented Mar 2, 2016

Awesome @trabus, thanks for finding that!

@trabus
Copy link
Contributor

trabus commented Mar 3, 2016

@marcoow reported the throws issue in #34 and will be fixed when #35 is merged.

@marcoow
Copy link
Author

marcoow commented Mar 3, 2016

@trabus: yay - thanks for that!

@trabus
Copy link
Contributor

trabus commented Mar 24, 2016

@marcoow just released v0.10.0 which should fix throws assertions for you. Thanks for your patience!

Turbo87 pushed a commit that referenced this issue Oct 17, 2018
Bumps [eslint-plugin-chai-expect](https://github.com/turbo87/eslint-plugin-chai-expect) from 1.1.1 to 2.0.1.
<details>
<summary>Release notes</summary>

*Sourced from [eslint-plugin-chai-expect's releases](https://github.com/turbo87/eslint-plugin-chai-expect/releases).*

> ## v1.2.0
> #### 🚀 Enhancement
> * [#19](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/19) Allow additional terminating properties to be configured ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> * [#21](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/21) Test against eslint version 4 ([[**thughes**](https://github.com/thughes)](https://github.com/thughes))
> 
> #### 🐛 Bug Fix
> * [#26](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/26) Fix expect finder utility ([[**brokentone**](https://github.com/brokentone)](https://github.com/brokentone))
> 
> #### 📝 Documentation
> * [#24](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/24) Document installation of this package as a devDependency ([[**astorije**](https://github.com/astorije)](https://github.com/astorije))
> * [#23](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/23) Document terminating-properties rule ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> 
> #### 🏠 Internal
> * [#16](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/16) Ignore ESLint updates on greenkeeper ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 5
> - Gordon Whamond ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> - Jérémie Astori ([[**astorije**](https://github.com/astorije)](https://github.com/astorije))
> - Kenton Jacobsen ([[**brokentone**](https://github.com/brokentone)](https://github.com/brokentone))
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> - Tom Hughes ([[**thughes**](https://github.com/thughes)](https://github.com/thughes))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [eslint-plugin-chai-expect's changelog](https://github.com/Turbo87/eslint-plugin-chai-expect/blob/master/CHANGELOG.md).*

> ## v2.0.1 (2018-10-13)
> 
> #### 🚀 Enhancement
> * [#35](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/35) Add `.npmignore` file ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 1
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> 
> ## v2.0.0 (2018-10-13)
> 
> #### 💥 Breaking Change
> * [#27](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/27) Drop support for Node.js 4 and below ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🚀 Enhancement
> * [#32](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/32) CI: Add ESLint 5 to the test matrix ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### 🏠 Internal
> * [#34](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/34) CI: Simplify job definition ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> * [#33](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/33) tests: Use same `espree` version as the `eslint` dependency ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> * [#31](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/31) Use yarn instead of npm ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 1
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> 
> ## v1.2.0 (2018-10-13)
> 
> #### 🚀 Enhancement
> * [#19](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/19) Allow additional terminating properties to be configured ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> * [#21](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/21) Test against eslint version 4 ([[**thughes**](https://github.com/thughes)](https://github.com/thughes))
> 
> #### 🐛 Bug Fix
> * [#26](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/26) Fix expect finder utility ([[**brokentone**](https://github.com/brokentone)](https://github.com/brokentone))
> 
> #### 📝 Documentation
> * [#24](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/24) Document installation of this package as a devDependency ([[**astorije**](https://github.com/astorije)](https://github.com/astorije))
> * [#23](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/23) Document terminating-properties rule ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> 
> #### 🏠 Internal
> * [#16](https://github-redirect.dependabot.com/Turbo87/eslint-plugin-chai-expect/pull/16) Ignore ESLint updates on greenkeeper ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> 
> #### Committers: 5
> - Gordon Whamond ([[**whamondg**](https://github.com/whamondg)](https://github.com/whamondg))
> - Jérémie Astori ([[**astorije**](https://github.com/astorije)](https://github.com/astorije))
> - Kenton Jacobsen ([[**brokentone**](https://github.com/brokentone)](https://github.com/brokentone))
> - Tobias Bieniek ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87))
> - Tom Hughes ([[**thughes**](https://github.com/thughes)](https://github.com/thughes))
</details>
<details>
<summary>Commits</summary>

- [`68e8759`](Turbo87/eslint-plugin-chai-expect@68e8759) v2.0.1
- [`23f6ba1`](Turbo87/eslint-plugin-chai-expect@23f6ba1) Update Changelog
- [`b7c2292`](Turbo87/eslint-plugin-chai-expect@b7c2292) Merge pull request [#35](https://github-redirect.dependabot.com/turbo87/eslint-plugin-chai-expect/issues/35) from Turbo87/npmignore
- [`4107ebc`](Turbo87/eslint-plugin-chai-expect@4107ebc) Add `.npmignore` file
- [`cae3114`](Turbo87/eslint-plugin-chai-expect@cae3114) v2.0.0
- [`54bd372`](Turbo87/eslint-plugin-chai-expect@54bd372) Update Changelog
- [`3b1b6cf`](Turbo87/eslint-plugin-chai-expect@3b1b6cf) README: Add `Requirements` section
- [`c1dd013`](Turbo87/eslint-plugin-chai-expect@c1dd013) Merge pull request [#34](https://github-redirect.dependabot.com/turbo87/eslint-plugin-chai-expect/issues/34) from Turbo87/ci-refactor
- [`5377469`](Turbo87/eslint-plugin-chai-expect@5377469) CI: Simplify job definition
- [`db148b4`](Turbo87/eslint-plugin-chai-expect@db148b4) Update eslint requirement from 2.1.0 to 5.7.0
- Additional commits viewable in [compare view](Turbo87/eslint-plugin-chai-expect@v1.1.1...v2.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=eslint-plugin-chai-expect&package-manager=npm_and_yarn&previous-version=1.1.1&new-version=2.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-chai-expect&package-manager=npm_and_yarn&previous-version=1.1.1&new-version=2.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

Dependabot will **not** automatically merge this PR because it includes a major update to a development dependency.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants