Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting configuration to work with TypeScript (+Prettier) #188

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Aug 21, 2020

This PR is quite large, but it's split into two commits:

  1. Adds the required linting config
  2. Reformats all files using prettier

My suggestion is to view the first changes, as they're the relevant ones.

Note: I added an extra config for linting in the package.json, so that end-users' workflows were preserved. The reason I added a new on is that, once we convert to .ts files, running yarn lint:js doesn't make as much sense.

@rwjblue
Copy link
Member

rwjblue commented Aug 21, 2020

Needs a rebase...

@rwjblue
Copy link
Member

rwjblue commented Aug 21, 2020

@scalvert is the second commit essentially yarn eslint . --fix?

@scalvert
Copy link
Contributor Author

prettier --write .

@scalvert
Copy link
Contributor Author

@rwjblue I rebased.

.eslintrc.js Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
scalvert and others added 2 commits August 21, 2020 09:21
Co-authored-by: Robert Jackson <me@rwjblue.com>
Co-authored-by: Robert Jackson <me@rwjblue.com>
@rwjblue rwjblue merged commit e254eba into ember-a11y:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants