Add support for migrating to TypeScript #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should talk more about this first, I think. |
|
Can you enumerate your concerns? I'd love to see if we can address them here. |
474ec25 to
21aa1ec
Compare
|
@MelSumner @drewlee @rwjblue and I discussed the concerns offline. It was largely around ensuring that we don't negatively affect consumers (absolutely), ensure we're careful about the types we publish (agree), and are clear about the specifics on how to address semver releases WRT types (will link to specifics in ember-cli-typescript once this PR is merged). |
rwjblue
approved these changes
Aug 20, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the
ember-cli-typescriptblueprint to this repository.