Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to div[role="region"], update messages, and add tests #11

Merged
merged 2 commits into from
Dec 10, 2017

Conversation

kmillns
Copy link
Contributor

@kmillns kmillns commented Nov 8, 2017

Addresses:
#8 - Default use of component throws error

  • Warns instead of errors and defaults to div[role="region"]

#7 - Assertions for only a tagName or a landmarkRole?

  • Updates assert messaging to match use of either div or form with landmarkRole

@kmillns
Copy link
Contributor Author

kmillns commented Nov 8, 2017

@EndangeredMassa was told you should review this to see if we're missing something in the logic.

@MelSumner MelSumner merged commit d2004f6 into ember-a11y:master Dec 10, 2017
@MelSumner
Copy link
Member

Thank you @kmillns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants