-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add documentation #1567
fix: Add documentation #1567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work so far, I really like it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Added some suggested edits.
1. Open a PR at https://huggingface.co/spaces/mteb/leaderboard modifying app.py to add your tab: | ||
- Add any new models & their specs to the global lists | ||
- Add your tab, credits etc to where the other tabs are defined | ||
- If you're adding new results to existing models, remove those models from `EXTERNAL_MODEL_RESULTS.json` such that they can be reloaded with the new results and are not cached. | ||
- You may also have to uncomment `, download_mode='force_redownload', verification_mode="no_checks")` where the datasets are loaded to experiment locally without caching of results | ||
- Test that it runs & works locally as you desire with python app.py, **please add screenshots to the PR** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only for adding a new tab to the leaderboard, or every time a new model is added?
If it's the latter, then 3 PRs are needed to add a new model: MTEB repo, results repo, and leaderboard repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing should be needed to the leaderboard repo
Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
Updated docs and merged everything. I merge this into the branch now |
I had some time on a plane so I made a documentation page!! I initially was thinking of moving everything there, but there were too many problems (especially with circular imports encountered when using the autodoc function) so I decided to work only on the API documentation which we currently don't have.
Therefore there are a lot of changes that are currently not used in the docs. The hope is that after this PR we can resolve some of these issues.
Here are some examples of the docs: