borg-activate: Extend load-path before loading autoloads #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsius
added a commit
that referenced
this pull request
Feb 5, 2024
Autoload files are supposed to add the containing directory to the `load-path'. This was lost when `autoload' was deprecated in favor of `loaddefs-gen'. This is a known issue (see bug#63625). Use the same workaround as used by `package-generate-autoloads'. Instead of relying on `loaddefs-generate' to do it on its own, pass appropriate EXTRA-DATA to it. Closes #159.
|
Well, thanks for figuring out the correct fix or work-around. It takes a lot of experience to know all these intricacies in Emacs. |
|
You're welcome and thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
borg-activateto extendload-pathalways and unconditionally before loading autoloads.The current code only extends
load-pathafter loading the autoloads, and it does that also in a bit of a redundant way. Once as part of the localactivatefunction and then again outside as a fallback.edit: Sorry, I just realize I didn't motivate this PR. I tried to load el-patch with borg. That package emits a
(require 'el-patch-stub)into its autoloads file (seeel-patch.el). This then fails when borg tries to load the autoloads file. While that may be unconventional (?), it still seems reasonable to me to assume that a package is inload-pathbefore its autoload file is evaluated.