-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breadcrumb on headerline #1799
Conversation
9854384
to
65fd46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
lsp-mode.el
Outdated
"Convert SYMBOL-INFORMATIONS to symbols hierarchy." | ||
(seq-some (-lambda ((symbol &as &SymbolInformation :location (&Location :range))) | ||
(-let (((beg . end) (lsp--range-to-region range))) | ||
(and (<= beg (point) end) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when tested manually, when I move outside of an element with one char it still stays the same, so probably something here is off by one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get this problem with lsp-dart
, could you provide more details? Maybe the dart or other server is sending different ranges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, seems like the issue is lack of refresh mentioned bellow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so I guess it's fixed now after adding (force-modeline-update)
Can you merge it in plists branch as well? Few things that can be addressed in the future:
|
|
I think that it looks fine in vscode. We could limit the length and use some kind of strategy to shorten the path(e. g. replace with the first letter of the directory). Anyways, it won't be a feature for everyone. Just to make sure we are on the same page, the proposal is to you the file name relative to project root. |
lsp-headerline-breadcrumb-mode
:Full screenshot:

In a next PR, the idea is to add mouse support to breadcrumb.