Display the first line of MarkupContent in eldoc #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many LSP servers, like gopls, return `document/onHover` as MarkupContent. This modifies the eldoc behavior to support MarkupContent by displaying the first rendered line. As the majority of LSP servers return the signature, this will display the signature as most people expect. In the future, microsoft/language-server-protocol#772 should make this more reliable.
yyoncho
reviewed
Apr 23, 2020
|
Thank you for contributing to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many LSP servers, like gopls, return
document/onHoverasMarkupContent. This modifies the eldoc behavior to support MarkupContent
by displaying the first rendered line. As the majority of LSP servers
return the signature, this will display the signature as most people expect.
In the future, microsoft/language-server-protocol#772 should make this more reliable.