Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lang file key #5

Closed
exzhawk opened this issue Jan 13, 2018 · 1 comment
Closed

Change lang file key #5

exzhawk opened this issue Jan 13, 2018 · 1 comment

Comments

@exzhawk
Copy link

exzhawk commented Jan 13, 2018 •
edited
Loading

Forge 2555, Better Boilers master-1.1.29, Storage Drawers 1.12.1-5.3.3
rr e2d b60bvmk412c 1ku
https://github.com/elytra/BetterBoilers/blob/master/src/main/resources/assets/betterboilers/lang/en_US.lang#L12
https://github.com/jaquadro/StorageDrawers/blob/1.12/resources/assets/storagedrawers/lang/en_us.lang#L75
You are using the same key.
Hmmmmm...
https://github.com/search?utf8=%E2%9C%93&q=%22tile.controller.name%22+extension%3Alang&type=Code&ref=advsearch&l=&l=
@LemmaEOF
Copy link
Member

…oh, right. I forgot that lang files aren't namespaced. Fixed, gonna release version 1.1.1 in just a bit incorporating fixes for this and #3

@LemmaEOF LemmaEOF mentioned this issue Jan 13, 2018
Merged
LemmaEOF added a commit that referenced this issue Jan 13, 2018
@LemmaEOF
Fix localization key and scanning validation, closes #3 and #5
6619e37
This was referenced May 11, 2018
Closed
Closed
@3TUSK 3TUSK mentioned this issue Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LemmaEOF @exzhawk