Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline editor: allow for changing of the notebook [name/location] #732

Closed
ptitzler opened this issue Jul 9, 2020 · 2 comments · Fixed by #867
Closed

Pipeline editor: allow for changing of the notebook [name/location] #732

ptitzler opened this issue Jul 9, 2020 · 2 comments · Fixed by #867
Assignees
@vabarbosa
Labels
feedback:user kind:enhancement New feature or request
Milestone
1.1.0

Comments

@ptitzler
Copy link
Member

ptitzler commented Jul 9, 2020 •
edited
Loading

As a user I would like to change the notebook name or location of a node. Currently the node properties display the name/location but do not allow for editing. Therefore if a user wants to change the name/location of a notebook the following steps need to be completed::

  • create a new node for the "renamed" notebook
  • select a runtime container
  • copy and paste "file dependencies"
  • copy and paste environment variables
  • copy and paste "output files"
  • remove old node
  • link notebook nodes

With this proposed enhancement a user would only have to change the name/location of the notebook.

image
@ptitzler ptitzler added kind:enhancement New feature or request feedback:user labels Jul 9, 2020
@ajbozarth
Copy link
Member

Bringing this under the umbrella issue #822 to handle updating a node's file location

@ajbozarth
Copy link
Member

A quick note on implementation: We definitely do not want to make this update via a text fields, but some form of UI. (as per previous discussions around this topic)

@ajbozarth ajbozarth added this to the 1.1.0 milestone Aug 5, 2020
@ajbozarth ajbozarth mentioned this issue Aug 6, 2020
Closed
11 tasks
@vabarbosa vabarbosa self-assigned this Aug 10, 2020
vabarbosa added a commit to vabarbosa/elyra that referenced this issue Aug 17, 2020
@vabarbosa
Update node properties to allow changing file
cadd6ab 
Added a file browser dialog and added support for changing file from the properties dialog

Fixes elyra-ai#732
@vabarbosa vabarbosa mentioned this issue Aug 17, 2020
Merged
lresende pushed a commit that referenced this issue Aug 18, 2020
@vabarbosa
Enable updating notebook file in pipeline node properties (#867)
d5ac043 
Added a file browser dialog to support changing the associated file
(e.g notebook) from the node properties dialog

Fixes #732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vabarbosa vabarbosa

Labels
feedback:user kind:enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Update node properties to allow changing file vabarbosa/elyra
3 participants
@ptitzler @vabarbosa @ajbozarth