Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests don't run if port is being used #1011

Closed
karlaspuldaro opened this issue Oct 27, 2020 · 0 comments · Fixed by #1024
Closed

Integration tests don't run if port is being used #1011

karlaspuldaro opened this issue Oct 27, 2020 · 0 comments · Fixed by #1024
Assignees
Labels
component:test Test-related
Milestone

Comments

@karlaspuldaro
Copy link
Member

Cypress tests should be able to run on another port when 8888 is used.
Trying to run make test-ui-debug command while lab is running would fail.

Command Line Output
npm run test:integration:debug
> elyra@1.4.0-dev test:integration:debug /Users/kspuldaro/github/elyra
> start-server-and-test start-jupyter http-get://localhost:8888?token=test cy:open
starting server using command "npm run start-jupyter"
and when url "http-get://localhost:8888?token=test" is responding
running tests using command "cy:open"
> elyra@1.4.0-dev start-jupyter /Users/kspuldaro/github/elyra
> mkdir -p build/cypress-tests && jupyter lab --config=./tests/test-config.py
[I 17:12:08.948 LabApp] The port 8888 is already in use.
[C 17:12:08.948 LabApp] ERROR: the notebook server could not be started because port 8888 is not available.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! elyra@1.4.0-dev start-jupyter: `mkdir -p build/cypress-tests && jupyter lab --config=./tests/test-config.py`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the elyra@1.4.0-dev start-jupyter script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/kspuldaro/.npm/_logs/2020-10-27T21_12_09_022Z-debug.log
Error: server closed unexpectedly
    at ChildProcess.onClose (/Users/kspuldaro/github/elyra/node_modules/start-server-and-test/src/index.js:60:14)
    at ChildProcess.emit (events.js:321:20)
    at maybeClose (internal/child_process.js:1026:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! elyra@1.4.0-dev test:integration:debug: `start-server-and-test start-jupyter http-get://localhost:8888?token=test cy:open`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the elyra@1.4.0-dev test:integration:debug script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/kspuldaro/.npm/_logs/2020-10-27T21_12_09_097Z-debug.log
make: *** [test-ui-debug] Error 1
@karlaspuldaro karlaspuldaro added the component:test Test-related label Oct 27, 2020
@karlaspuldaro karlaspuldaro added this to the 1.4.0 milestone Oct 27, 2020
@akchinSTC akchinSTC self-assigned this Oct 28, 2020
akchinSTC added a commit to akchinSTC/elyra that referenced this issue Oct 30, 2020
Current UI tests will fail if jupyter lab or any other application
is using port 8888. The issue is resolved by Using an explicit
non-registered port >=49152

Fixes elyra-ai#1011
lresende pushed a commit that referenced this issue Oct 30, 2020
Current UI tests will fail if jupyter lab or any other application
is using port 8888. The issue is resolved by Using an explicit
non-registered port >=49152

Fixes #1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants