Panic when using modules that loaded with exception #1257

zzamboni · 2021-02-28T13:35:08Z

If a used module contains an error, Elvish crashes upon any attempt at accessing its namespace.

[~]|> elvish -buildinfo
Version: v0.16.0-dev.f3bef66ee2992200ff6bfba0e6b26128631a173b
Go version: go1.16
Reproducible build: true

For example, if ~/.elvish/lib/test.elv contains the following:

put $foobar

Then:

[~]|> elvish
[~]|> use test
Exception: compilation error: variable $foobar not found
/Users/taazadi1/.elvish/lib/test.elv, line 1: put $foobar
[tty 1], line 1: use test

Now I type test: followed by t (any other key works too), Elvish panics the moment I type the key following the colon:

[~]|> test:panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1255ee6]

goroutine 19424 [running]:
src.elv.sh/pkg/eval.(*Ns).lookup(0x0, 0xc0007d4cf8, 0x2, 0x2)
	src.elv.sh/pkg/eval/ns.go:101 +0x26
src.elv.sh/pkg/eval.(*Ns).IndexName(...)
	src.elv.sh/pkg/eval/ns.go:93
src.elv.sh/pkg/eval.(*Ns).Index(0x0, 0x12e37a0, 0xc0007d4d18, 0x1359b5d, 0x1, 0xc0007d4cf8)
	src.elv.sh/pkg/eval/ns.go:80 +0x5a
src.elv.sh/pkg/edit.hasFn(0x0, 0xc0006aeac9, 0x1, 0x1)
	src.elv.sh/pkg/edit/highlight.go:97 +0x96
src.elv.sh/pkg/edit.hasQualifiedFn(0xc00014b1e0, 0xc0006aeac4, 0x5, 0xc0006aeac9, 0x1, 0x1)
	src.elv.sh/pkg/edit/highlight.go:93 +0x1ca
src.elv.sh/pkg/edit.hasCommand(0xc00014b1e0, 0xc0006aeac4, 0x6, 0xc0004606d8)
	src.elv.sh/pkg/edit/highlight.go:58 +0x11d
src.elv.sh/pkg/edit.initHighlighter.func2(0xc0006aeac4, 0x6, 0x1)
	src.elv.sh/pkg/edit/highlight.go:17 +0x3e
src.elv.sh/pkg/edit/highlight.highlight.func1(0xc00079e0f0, 0x1, 0x1, 0xc0002d3a40, 0x1, 0x1, 0xc000098200, 0xc000098210, 0xc00008e300)
	src.elv.sh/pkg/edit/highlight/highlight.go:104 +0xe3
created by src.elv.sh/pkg/edit/highlight.highlight
	src.elv.sh/pkg/edit/highlight/highlight.go:100 +0xb65
Exception: elvish exited with 2
[tty 4], line 1: elvish

Trying again, now I type test: followed by Tab, which produces a longer backtrace:

[~]|> elvish
[~]|> use test
Exception: compilation error: variable $foobar not found
/Users/taazadi1/.elvish/lib/test.elv, line 1: put $foobar
[tty 1], line 1: use test
[~]|> test:
goroutine 1 [running]:
src.elv.sh/pkg/sys.DumpStack(0xc0001bc280, 0x12fc080)
	src.elv.sh/pkg/sys/dumpstack.go:10 +0x9f
src.elv.sh/pkg/shell.handlePanic()
	src.elv.sh/pkg/shell/interact.go:39 +0x8a
panic(0x12fc080, 0x154f8a0)
	runtime/panic.go:965 +0x1b9
src.elv.sh/pkg/eval.(*Ns).IterateNames(0x0, 0xc0003cec00)
	src.elv.sh/pkg/eval/ns.go:125 +0x26
src.elv.sh/pkg/edit.eachVariableInTop(0xc0002c6050, 0xc0004335e0, 0xc000a90560, 0x5, 0xc0003cec00)
	src.elv.sh/pkg/edit/ns_helper.go:43 +0x245
src.elv.sh/pkg/edit.pureEvaler.EachVariableInNs(0xc0001531e0, 0xc000a90560, 0x5, 0xc0003cec00)
	src.elv.sh/pkg/edit/completion.go:527 +0x71
src.elv.sh/pkg/edit/complete.generateCommands(0xc000a90560, 0x5, 0x13bfb78, 0xc0001531e0, 0xc000a90560, 0x5, 0xc0005e6f60, 0x0, 0xc0005e6f48)
	src.elv.sh/pkg/edit/complete/generators.go:76 +0x1f4
src.elv.sh/pkg/edit/complete.completeCommand(0x13bccb0, 0xc0005ba0c0, 0x13bfb78, 0xc0001531e0, 0xc0003ce8a0, 0xc000150300, 0x0, 0xc0005e6f00, 0x135caa9, 0xd, ...)
	src.elv.sh/pkg/edit/complete/completers.go:93 +0x309
src.elv.sh/pkg/edit/complete.Complete(0xc000a90560, 0x5, 0x5, 0x13bfb78, 0xc0001531e0, 0xc0003ce8a0, 0xc000150300, 0x0, 0x0, 0xc0001bc9b8)
	src.elv.sh/pkg/edit/complete/complete.go:92 +0x226
src.elv.sh/pkg/edit.completionStart(0x13c06f8, 0xc0001e4000, 0x13b7be8, 0xc0001c6600, 0x13bfb78, 0xc0001531e0, 0xc0003ce8a0, 0xc000150300, 0xc0001bcb01)
	src.elv.sh/pkg/edit/completion.go:164 +0xf5
src.elv.sh/pkg/edit.initCompletion.func4()
	src.elv.sh/pkg/edit/completion.go:248 +0xaa
reflect.Value.call(0x12decc0, 0xc0001c6630, 0x13, 0x1359f38, 0x4, 0x0, 0x0, 0x0, 0xc0001bcdf8, 0x0, ...)
	reflect/value.go:476 +0x8e7
reflect.Value.Call(0x12decc0, 0xc0001c6630, 0x13, 0x0, 0x0, 0x0, 0x300000002, 0xc000000180, 0xc0001bcf10)
	reflect/value.go:337 +0xb9
src.elv.sh/pkg/eval.(*goFn).Call(0xc0001e3260, 0xc00058c540, 0x0, 0x0, 0x0, 0xc00010f3b0, 0xc0006c07e0, 0x3)
	src.elv.sh/pkg/eval/go_fn.go:237 +0x678
src.elv.sh/pkg/eval.(*Evaler).Call(0xc0001531e0, 0x13b7468, 0xc0001e3260, 0x0, 0x0, 0x0, 0xc00010f3b0, 0x135d8c2, 0x10, 0xc0006c07e0, ...)
	src.elv.sh/pkg/eval/eval.go:491 +0x273
src.elv.sh/pkg/edit.callWithNotifyPorts(0x13b95a0, 0xc0001c42c0, 0xc0001531e0, 0x13b7468, 0xc0001e3260, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/edit/key_binding.go:67 +0x1d2
src.elv.sh/pkg/edit.mapBindings.Handle(0x13b95a0, 0xc0001c42c0, 0xc0001531e0, 0xc000128bb8, 0x1, 0x1, 0x13b9500, 0xc0001e6000, 0x13b7aa8, 0xc0006de120, ...)
	src.elv.sh/pkg/edit/key_binding.go:41 +0x1c5
src.elv.sh/pkg/cli/tk.(*codeArea).handleKeyEvent(0xc0001e6000, 0x9, 0x13b9500)
	src.elv.sh/pkg/cli/tk/codearea.go:289 +0x127
src.elv.sh/pkg/cli/tk.(*codeArea).Handle(0xc0001e6000, 0x13b7aa8, 0xc0006de118, 0x13b9500)
	src.elv.sh/pkg/cli/tk/codearea.go:164 +0xc5
src.elv.sh/pkg/cli.(*app).handle(0xc0001e4000, 0x1322c20, 0xc0006de118)
	src.elv.sh/pkg/cli/app.go:196 +0x231
src.elv.sh/pkg/cli.(*loop).Run(0xc0001c45c0, 0xc000100201, 0xc0000964e0, 0xc0001e4000, 0xc00001bfa0)
	src.elv.sh/pkg/cli/loop.go:129 +0x16f
src.elv.sh/pkg/cli.(*app).ReadCode(0xc0001e4000, 0x0, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/cli/app.go:365 +0x3f9
src.elv.sh/pkg/edit.(*Editor).ReadCode(0xc0001c42c0, 0xc00011e010, 0x13b73c8, 0xc0001e8960, 0xc000a90548)
	src.elv.sh/pkg/edit/editor.go:102 +0x33
src.elv.sh/pkg/shell.Interact(0xc00011e000, 0xc00011e008, 0xc00011e010, 0xc0001bdcb8)
	src.elv.sh/pkg/shell/interact.go:81 +0x4b0
src.elv.sh/pkg/shell.program.Run(0xc00011e000, 0xc00011e008, 0xc00011e010, 0xc0001a7490, 0xc00010a1d0, 0x0, 0x0, 0x1587740, 0xc00014df68)
	src.elv.sh/pkg/shell/shell.go:40 +0x2de
src.elv.sh/pkg/prog.Run(0xc00011e000, 0xc00011e008, 0xc00011e010, 0xc00010a1d0, 0x1, 0x1, 0xc00014df48, 0x3, 0x3, 0x0)
	src.elv.sh/pkg/prog/prog.go:136 +0x258
main.main()
	src.elv.sh/cmd/elvish/main.go:17 +0x11f

goroutine 34 [chan receive]:
src.elv.sh/pkg/eval.getBlackholeChan.func1(0xc000100120)
	src.elv.sh/pkg/eval/port.go:67 +0x47
created by src.elv.sh/pkg/eval.getBlackholeChan
	src.elv.sh/pkg/eval/port.go:66 +0x58

goroutine 36 [syscall]:
os/signal.signal_recv(0x13b9cf8)
	runtime/sigqueue.go:165 +0x9d
os/signal.loop()
	os/signal/signal_unix.go:23 +0x25
created by os/signal.Notify.func1.1
	os/signal/signal.go:151 +0x45

goroutine 38 [chan receive]:
src.elv.sh/pkg/shell.setupShell.func1(0xc0001208a0, 0xc00011e000, 0xc00011e008, 0xc00011e010)
	src.elv.sh/pkg/shell/shell.go:51 +0xa5
created by src.elv.sh/pkg/shell.setupShell
	src.elv.sh/pkg/shell/shell.go:50 +0xf9

goroutine 39 [chan receive]:
src.elv.sh/pkg/cli/prompt.(*Prompt).loop(0xc0001e20e0)
	src.elv.sh/pkg/cli/prompt/prompt.go:77 +0xc8
created by src.elv.sh/pkg/cli/prompt.New
	src.elv.sh/pkg/cli/prompt/prompt.go:70 +0x165

goroutine 40 [chan receive]:
src.elv.sh/pkg/cli/prompt.(*Prompt).loop(0xc0001e21c0)
	src.elv.sh/pkg/cli/prompt/prompt.go:77 +0xc8
created by src.elv.sh/pkg/cli/prompt.New
	src.elv.sh/pkg/cli/prompt/prompt.go:70 +0x165

goroutine 11975 [syscall]:
syscall.syscall6(0x10822c0, 0x4d49, 0xc000a0baf4, 0x0, 0xc0007a8090, 0x0, 0x0, 0x0, 0x0, 0x0)
	runtime/sys_darwin.go:41 +0x2e
syscall.wait4(0x4d49, 0xc000a0baf4, 0x0, 0xc0007a8090, 0x90, 0x1351d60, 0x1)
	syscall/zsyscall_darwin_amd64.go:44 +0x85
syscall.Wait4(0x4d49, 0xc000a0bb44, 0x0, 0xc0007a8090, 0x47, 0xc00050ca20, 0x6)
	syscall/syscall_bsd.go:144 +0x51
os.(*Process).wait(0xc000832000, 0x47, 0xc00050ca20, 0x6)
	os/exec_unix.go:43 +0x85
os.(*Process).Wait(...)
	os/exec.go:129
src.elv.sh/pkg/eval.externalCmd.Call(0xc000016550, 0x47, 0xc00074e0e0, 0xc0002b6000, 0x5, 0x8, 0xc000620360, 0xc000373800, 0xc000016410)
	src.elv.sh/pkg/eval/external_cmd.go:97 +0x365
src.elv.sh/pkg/eval.(*formOp).exec(0xc0005c3550, 0xc00074e0e0, 0x0, 0x0)
	src.elv.sh/pkg/eval/compile_effect.go:376 +0x9a2
src.elv.sh/pkg/eval.(*pipelineOp).exec.func1(0x13b7448, 0xc0005c3550, 0xc00074e0e0, 0xc000500600, 0xc0002340b0, 0xc000426c00)
	src.elv.sh/pkg/eval/compile_effect.go:117 +0x3f
created by src.elv.sh/pkg/eval.(*pipelineOp).exec
	src.elv.sh/pkg/eval/compile_effect.go:116 +0x225

goroutine 11976 [semacquire]:
sync.runtime_Semacquire(0xc0002340b8)
	runtime/sema.go:56 +0x45
sync.(*WaitGroup).Wait(0xc0002340b0)
	sync/waitgroup.go:130 +0x65
src.elv.sh/pkg/eval.(*pipelineOp).exec.func2(0xc0002340b0, 0xc00074e070, 0xc0005b2f40, 0xc000500600, 0x1, 0x1)
	src.elv.sh/pkg/eval/compile_effect.go:137 +0x45
created by src.elv.sh/pkg/eval.(*pipelineOp).exec
	src.elv.sh/pkg/eval/compile_effect.go:136 +0x29c

runtime error: invalid memory address or nil pointer dereference

Execing recovery shell /bin/sh
sh-3.2$

The text was updated successfully, but these errors were encountered:

krader1961 · 2021-03-07T04:58:40Z

@zzamboni, You should be a test engineer. Note that your reproduction only affects interactive shells. The non-interactive equivalent behaves as expected; i.e., no panic.

> ./elvish -c 'try { use bad } except x { put WTF $x }
                                                   bad:x'
▶ WTF
▶ [&reason=<unknown parse error: 25-25 in /Users/krader/.elvish/lib/bad.elv: should be ']'>]
Exception: exec: "bad:x": executable file not found in $PATH
code from -c, line 2:     bad:x
Exception: ./elvish exited with 2
[tty 224], line 1-2: ./elvish -c 'try { use bad } except x { put WTF $x }
                         bad:x'

TBD is why the interactive context mutates the global list of namespaces to include an invalid module while the non-interactive context does not.

zzamboni · 2021-03-07T13:50:04Z

@krader1961 interesting. With an example like yours, it indeed does not crash:

> elvish -c 'try { use test } except e { put $e }; test:x'
▶ [&reason=<unknown compilation error: 4-11 in /Users/taazadi1/.elvish/lib/test.elv: variable $foobar not found>]
Exception: exec: "test:x": executable file not found in $PATH
code from -c, line 1: try { use test } except e { put $e }; test:x
Exception: elvish exited with 2
[tty 2], line 1: elvish -c 'try { use test } except e { put $e }; test:x'

However, if I don't use try/except, I still get the crash even noninteractively:

> elvish -c 'e = ?(use test); put $e
                         test:x'
▶ [&reason=<unknown compilation error: 4-11 in /Users/taazadi1/.elvish/lib/test.elv: variable $foobar not found>]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1255ee6]

goroutine 28 [running]:
src.elv.sh/pkg/eval.(*Ns).lookup(0x0, 0xc0000a90d5, 0x2, 0xc0000a49d8)
	src.elv.sh/pkg/eval/ns.go:101 +0x26
src.elv.sh/pkg/eval.(*Ns).IndexName(...)
	src.elv.sh/pkg/eval/ns.go:93
src.elv.sh/pkg/eval.deref(0xc0001be700, 0xc00008dbf0, 0xc000072ac0, 0x10cfb19)
	src.elv.sh/pkg/eval/var_ref.go:135 +0xd5
src.elv.sh/pkg/eval.variableOp.exec(0x18, 0x1e, 0x0, 0xc0000a90d7, 0x7, 0xc00008dbf0, 0xc0001be700, 0xc0000fdf70, 0x8, 0x1, ...)
	src.elv.sh/pkg/eval/compile_value.go:317 +0x4d
src.elv.sh/pkg/eval.evalForValue(0xc0001be700, 0x13b9bb8, 0xc00008dc20, 0x135abe2, 0x7, 0x7ffeefbff8c2, 0x4, 0xc0001c44d0, 0x1262ee5)
	src.elv.sh/pkg/eval/compile_value.go:577 +0x48
src.elv.sh/pkg/eval.evalForCommand(0xc0001be700, 0x13b9bb8, 0xc00008dc20, 0x135abe2, 0x7, 0x0, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/eval/compile_effect.go:384 +0x74
src.elv.sh/pkg/eval.(*formOp).exec(0xc0000ae9a0, 0xc0001be700, 0x0, 0x0)
	src.elv.sh/pkg/eval/compile_effect.go:346 +0x609
src.elv.sh/pkg/eval.(*pipelineOp).exec.func1(0x13b7448, 0xc0000ae9a0, 0xc0001be700, 0xc0001ca030, 0xc0000a9150, 0x203000)
	src.elv.sh/pkg/eval/compile_effect.go:117 +0x3f
created by src.elv.sh/pkg/eval.(*pipelineOp).exec
	src.elv.sh/pkg/eval/compile_effect.go:116 +0x225
Exception: elvish exited with 2
[tty 1], line 1-2: elvish -c 'e = ?(use test); put $e
                   test:x'

xiaq · 2021-03-10T23:21:18Z

Hmm, the behavior is specific to interactive shells because a failed import would cause an exception and abort the surrounding block. In non-interactive cases this would normally cause the surrounding namespace to become inaccessible, so the broken variable doesn't matter (unless the exception is swallowed by ?(); you can construct a similar repro with it in a non-interactive script). The interactive case is different as the REPL will still pick up the broken variable.

I'll need to think a bit about how to best handle this.

krader1961 · 2021-03-14T03:16:04Z

I'll need to think a bit about how to best handle this.

I spent a couple of hours using my (unmerged) trace package to understand the dynamics of this unexpected behavior in the hope I could identify an obvious fix. I failed to find a simple fix. ☹️

It's not clear this should be a blocking bug for the next point release. All bugs should be fixed ASAP but this is primarily a UI bug that few people (close to zero in my estimation) will ever notice.

Xjs · 2021-04-23T13:01:31Z

Not entirely sure if relevant, but I can trigger a crash in the same function (src.elv.sh/pkg/eval.(*Ns).lookup) by doing the following:

Start an interactive shell
Type the following commands:

str:split "abc" "b"
fail; use str # it appears necessary that the line fails in which an import is performed

Use the up arrow key twice to cycle back to the "str:split" command.

I can reliably reproduce a SIGSEGV panic with the following backtrace on df3e7a9:

panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x100f619c0]

goroutine 4591 [running]:
src.elv.sh/pkg/eval.(*Ns).lookup(0x0, 0x14000339cf8, 0x6, 0x6)
	/Users/jannis/src/github.com/elves/elvish/pkg/eval/ns.go:100 +0x20
src.elv.sh/pkg/eval.(*Ns).IndexName(...)
	/Users/jannis/src/github.com/elves/elvish/pkg/eval/ns.go:92
src.elv.sh/pkg/eval.(*Ns).Index(0x0, 0x1010458a0, 0x14000339d18, 0x100fb7ffd, 0x1, 0x14000339cf8)
	/Users/jannis/src/github.com/elves/elvish/pkg/eval/ns.go:80 +0x50
src.elv.sh/pkg/edit.hasFn(0x0, 0x1400015dc24, 0x5, 0x1)
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight.go:93 +0x7c
src.elv.sh/pkg/edit.hasQualifiedFn(0x1400015f450, 0x1400015dc20, 0x4, 0x1400015dc24, 0x5, 0x5)
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight.go:89 +0x16c
src.elv.sh/pkg/edit.hasCommand(0x1400015f450, 0x1400015dc20, 0x9, 0x14000235ec0)
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight.go:54 +0xe0
src.elv.sh/pkg/edit.initHighlighter.func2(0x1400015dc20, 0x9, 0x8)
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight.go:17 +0x38
src.elv.sh/pkg/edit/highlight.highlight.func1(0x14000235d80, 0x5, 0x8, 0x1400028c318, 0x1, 0x1, 0x14000189e80, 0x14000189e90, 0x14
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight/highlight.go:104 +0xac
created by src.elv.sh/pkg/edit/highlight.highlight
	/Users/jannis/src/github.com/elves/elvish/pkg/edit/highlight/highlight.go:100 +0x858

zzamboni · 2021-04-23T19:03:06Z

I can reproduce the panic described by @Xjs.

[~]|> elvish -buildinfo
Version: v0.16.0-dev.df3e7a9268435d96b4432b517784e1358575ae3b
Go version: go1.16.3
Reproducible build: true

hanche · 2021-08-31T11:23:48Z

I found a new (?) way to crash elvish. I think it might have the same underlying cause as the present issue, so I post it here instead of opening a new one.

To reproduce, follow this transcript:

⬥ var z:
⬥ eval &on-end=[ns]{ set z: = $ns } 'will not compile }'
Exception: parse error: unexpected rune '}'
[eval 3], line 1: will not compile }
[tty 3], line 1: eval &on-end=[ns]{ set z: = $ns } 'will not compile }'
⬥ put $z:
⮕ <ns 0x0>

That 0x0 made me suspect I can trick elvish into accessing a null pointer. And so I can:

⬥ put $z:⟨TAB⟩
goroutine 1 [running]:
src.elv.sh/pkg/sys.DumpStack(0x140005b6518, 0x103053e00)
	src.elv.sh/pkg/sys/dumpstack.go:10 +0x8c
src.elv.sh/pkg/shell.handlePanic()
	src.elv.sh/pkg/shell/interact.go:142 +0x5c
panic(0x103053e00, 0x1032beda0)
	runtime/panic.go:965 +0x14c
src.elv.sh/pkg/eval.(*Ns).IterateNames(0x0, 0x14000302100)
	src.elv.sh/pkg/eval/ns.go:124 +0x20
src.elv.sh/pkg/edit.eachVariableInTop(0x140001a05a0, 0x1400055b4f0, 0x1400042d075, 0x2, 0x14000302100)
	src.elv.sh/pkg/edit/ns_helper.go:41 +0x1e4
src.elv.sh/pkg/edit.pureEvaler.EachVariableInNs(0x140000d8f70, 0x1400042d075, 0x2, 0x14000302100)
	src.elv.sh/pkg/edit/completion.go:541 +0x60
src.elv.sh/pkg/edit/complete.completeVariable(0x1030d0c50, 0x14000532240, 0x1030d4978, 0x140000d8f70, 0x14000350150, 0x14000168020, 0x0, 0x0, 0x0, 0x0, ...)
	src.elv.sh/pkg/edit/complete/completers.go:198 +0x1b4
src.elv.sh/pkg/edit/complete.Complete(0x1400042d070, 0x7, 0x7, 0x1030d4978, 0x140000d8f70, 0x14000350150, 0x14000168020, 0x0, 0x0, 0x6)
	src.elv.sh/pkg/edit/complete/complete.go:92 +0x174
src.elv.sh/pkg/edit.completionStart(0x1030d56d8, 0x14000120000, 0x1030ca408, 0x14000114c00, 0x1030d4978, 0x140000d8f70, 0x14000350150, 0x14000168020, 0x140005b6d01)
	src.elv.sh/pkg/edit/completion.go:164 +0xa4
src.elv.sh/pkg/edit.initCompletion.func4()
	src.elv.sh/pkg/edit/completion.go:249 +0x98
reflect.Value.call(0x1030311c0, 0x14000114c30, 0x13, 0x102f95037, 0x4, 0x0, 0x0, 0x0, 0x140005b7038, 0x102cc0220, ...)
	reflect/value.go:476 +0x650
reflect.Value.Call(0x1030311c0, 0x14000114c30, 0x13, 0x0, 0x0, 0x0, 0x12, 0x1034785e0, 0x140005b7038)
	reflect/value.go:337 +0x84
src.elv.sh/pkg/eval.(*goFn).Call(0x140001261c0, 0x1400040e000, 0x0, 0x0, 0x0, 0x14000182780, 0x1400012c000, 0x3)
	src.elv.sh/pkg/eval/go_fn.go:227 +0x530
src.elv.sh/pkg/eval.(*Evaler).Call(0x140000d8f70, 0x1030c9ba8, 0x140001261c0, 0x0, 0x0, 0x0, 0x14000182780, 0x102f99961, 0x10, 0x1400012c000, ...)
	src.elv.sh/pkg/eval/eval.go:491 +0x190
src.elv.sh/pkg/edit.callWithNotifyPorts(0x1030cc1a8, 0x1400009e900, 0x140000d8f70, 0x1030c9ba8, 0x140001261c0, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/edit/key_binding.go:67 +0x130
src.elv.sh/pkg/edit.mapBindings.Handle(0x1030cc1a8, 0x1400009e900, 0x140000d8f70, 0x140000b0c18, 0x1, 0x1, 0x1030cc108, 0x14000122000, 0x1030ca2c8, 0x1400042c030, ...)
	src.elv.sh/pkg/edit/key_binding.go:41 +0x17c
src.elv.sh/pkg/cli/tk.(*codeArea).handleKeyEvent(0x14000122000, 0x10000000009, 0x14000120000)
	src.elv.sh/pkg/cli/tk/codearea.go:289 +0xec
src.elv.sh/pkg/cli/tk.(*codeArea).Handle(0x14000122000, 0x1030ca2c8, 0x1400042c008, 0x1030ca201)
	src.elv.sh/pkg/cli/tk/codearea.go:164 +0xcc
src.elv.sh/pkg/cli/mode.(*histwalk).Handle(0x140007f40a0, 0x1030ca2c8, 0x1400042c008, 0x0)
	src.elv.sh/pkg/cli/mode/histwalk.go:52 +0xd0
src.elv.sh/pkg/cli.(*app).handle(0x14000120000, 0x10307d020, 0x1400042c008)
	src.elv.sh/pkg/cli/app.go:196 +0x1c8
src.elv.sh/pkg/cli.(*loop).Run(0x1400011e000, 0x1400008c101, 0x140001cc5a0, 0x14000120000, 0x14000596290)
	src.elv.sh/pkg/cli/loop.go:129 +0x100
src.elv.sh/pkg/cli.(*app).ReadCode(0x14000120000, 0x0, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/cli/app.go:365 +0x35c
src.elv.sh/pkg/edit.(*Editor).ReadCode(0x1400009e900, 0x1400009c010, 0x7, 0x1400042d070, 0x7)
	src.elv.sh/pkg/edit/editor.go:108 +0x34
src.elv.sh/pkg/shell.interact(0x140000d8f70, 0x1400009c000, 0x1400009c008, 0x1400009c010, 0x1400018bd98)
	src.elv.sh/pkg/shell/interact.go:99 +0x32c
src.elv.sh/pkg/shell.Program.Run(0x1030c0ac8, 0x1400009c000, 0x1400009c008, 0x1400009c010, 0x14000198080, 0x1400008e1d0, 0x0, 0x0, 0x0, 0x0)
	src.elv.sh/pkg/shell/shell.go:79 +0xf8
src.elv.sh/pkg/prog.Run(0x1400009c000, 0x1400009c008, 0x1400009c010, 0x1400008e1d0, 0x1, 0x1, 0x1400018bf38, 0x3, 0x3, 0x0)
	src.elv.sh/pkg/prog/prog.go:142 +0x298
main.main()
	src.elv.sh/cmd/elvish/main.go:18 +0xf8

goroutine 33 [chan receive, 3 minutes]:
src.elv.sh/pkg/eval.getBlackholeChan.func1(0x140001cc0c0)
	src.elv.sh/pkg/eval/port.go:96 +0x3c
created by src.elv.sh/pkg/eval.getBlackholeChan
	src.elv.sh/pkg/eval/port.go:95 +0x50

goroutine 34 [syscall]:
os/signal.signal_recv(0x1030cc9f0)
	runtime/sigqueue.go:165 +0xc4
os/signal.loop()
	os/signal/signal_unix.go:23 +0x20
created by os/signal.Notify.func1.1
	os/signal/signal.go:151 +0x44

goroutine 19 [chan receive]:
src.elv.sh/pkg/shell.initTTYAndSignal.func1(0x14000180300, 0x1030c9948, 0x1400009c010)
	src.elv.sh/pkg/shell/shell.go:130 +0x90
created by src.elv.sh/pkg/shell.initTTYAndSignal
	src.elv.sh/pkg/shell/shell.go:129 +0x64

goroutine 21 [chan receive]:
src.elv.sh/pkg/cli/prompt.(*Prompt).loop(0x140000d0d20)
	src.elv.sh/pkg/cli/prompt/prompt.go:77 +0xa0
created by src.elv.sh/pkg/cli/prompt.New
	src.elv.sh/pkg/cli/prompt/prompt.go:70 +0x154

goroutine 22 [chan receive]:
src.elv.sh/pkg/cli/prompt.(*Prompt).loop(0x140000d0e00)
	src.elv.sh/pkg/cli/prompt/prompt.go:77 +0xa0
created by src.elv.sh/pkg/cli/prompt.New
	src.elv.sh/pkg/cli/prompt/prompt.go:70 +0x154

runtime error: invalid memory address or nil pointer dereference

Initialization of variable slots were "hoisted" to the beginning of each scope. This commit moves that initialization to the command that declares the variable, which make it easier to resolve #1257 and #1235. Also properly handle variables that are created as part of a temporary assignment, addressing #532. There are some failing tests, which will be fixed in upcoming commits.

xiaq added the bug label Mar 10, 2021

xiaq added this to the 0.16.0 milestone Mar 10, 2021

xiaq modified the milestones: 0.16.0, 0.17.0 Oct 12, 2021

xiaq changed the title ~~Panic on loading module with errors~~ Panic when using modules that loaded with exception Oct 15, 2021

xiaq mentioned this issue Oct 23, 2021

Segfault during syntax highlighting #1412

Closed

xiaq closed this as completed in 14a81d1 Dec 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Panic when using modules that loaded with exception #1257

Panic when using modules that loaded with exception #1257

zzamboni commented Feb 28, 2021

krader1961 commented Mar 7, 2021

zzamboni commented Mar 7, 2021 •

edited

Loading

xiaq commented Mar 10, 2021

krader1961 commented Mar 14, 2021 •

edited

Loading

Xjs commented Apr 23, 2021 •

edited

Loading

zzamboni commented Apr 23, 2021

hanche commented Aug 31, 2021

Panic when using modules that loaded with exception #1257

Panic when using modules that loaded with exception #1257

Comments

zzamboni commented Feb 28, 2021

krader1961 commented Mar 7, 2021

zzamboni commented Mar 7, 2021 • edited Loading

xiaq commented Mar 10, 2021

krader1961 commented Mar 14, 2021 • edited Loading

Xjs commented Apr 23, 2021 • edited Loading

zzamboni commented Apr 23, 2021

hanche commented Aug 31, 2021

zzamboni commented Mar 7, 2021 •

edited

Loading

krader1961 commented Mar 14, 2021 •

edited

Loading

Xjs commented Apr 23, 2021 •

edited

Loading