implemented shape #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2019 10:54
crgant12
suggested changes
Jun 10, 2019
src/s2/shape.rs
Outdated
| } | ||
|
|
||
| // sortEdges sorts the slice of Edges in place. | ||
| pub fn sortEdges(e: Vec<Edge>) -> Vec<Edge> { |
There was a problem hiding this comment.
This probably needs to be done like this example https://rust-lang-nursery.github.io/rust-cookbook/algorithms/sorting.html
src/s2/shape.rs
Outdated
|
|
||
| impl Edges { | ||
|
|
||
| pub fn Len(&self, ) -> i64 { len(self) } |
There was a problem hiding this comment.
This is for go's way of sorting things. You probably don't need this.
src/s2/shape.rs
Outdated
| fn IsFull() -> bool; | ||
|
|
||
| // We do not support implementations of this interface outside this package. | ||
| privateInterface() |
There was a problem hiding this comment.
I would just take this out since it doesn't translate directory from go.
src/s2/shape.rs
Outdated
| // certain algorithms such as intersection (see BooleanOperation). | ||
| pub trait Shape { | ||
| // NumEdges returns the number of edges in this shape. | ||
| fn NumEdges() -> i64; |
added 2 commits
June 10, 2019 15:48
crgant12
suggested changes
Jun 12, 2019
crgant12
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.