[Feat: OTEL + Tenants] : Add TenantId Property to Span #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdevillard We can approve & merge this PR as soon as its marked "Ready for review". |
|
I wasn't sure about the tenantId vs TenantId in the Log. On OTEL side, it's explain that attribute naming SHOULD be lowercase, so If we want to respect, we should change a lot of attribute, let's go using the convention already present in this file ( |
|
Agreed, the casing is a separate discussion and shouldn't hold back this PR 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the
TenantIdproperty to the span for :The aim is to facilitate the querying in the end analysis tools
This change is