Merge pull request #6342 from elsa-workflows/vaidate-unique-input-output

Validate unique input/output names before publishing workflow

src/modules/Elsa.Workflows.Api/Endpoints/WorkflowDefinitions/BulkPublish/Endpoint.cs

@@ -70,6 +70,6 @@ public override async Task<Response> ExecuteAsync(Request request, CancellationT
                 updatedConsumers.AddRange(result.AffectedWorkflows.WorkflowDefinitions.Select(x => x.DefinitionId));
         }
 
-        return new Response(published, alreadyPublished, notFound, skipped, updatedConsumers);
+        return new(published, alreadyPublished, notFound, skipped, updatedConsumers);
     }
 }

src/modules/Elsa.Workflows.Management/Features/WorkflowManagementFeature.cs

@@ -241,6 +241,7 @@ public override void Apply()
             .AddNotificationHandler<DeleteWorkflowInstances>()
             .AddNotificationHandler<RefreshActivityRegistry>()
             .AddNotificationHandler<UpdateConsumingWorkflows>()
+            .AddNotificationHandler<ValidateWorkflow>()
             ;
 
         Services.Configure<ManagementOptions>(options =>

src/modules/Elsa.Workflows.Management/Handlers/Notification/ValidateWorkflow.cs

@@ -0,0 +1,31 @@
+using Elsa.Mediator.Contracts;
+using Elsa.Workflows.Management.Models;
+using Elsa.Workflows.Management.Notifications;
+using Elsa.Workflows.Models;
+
+namespace Elsa.Workflows.Management.Handlers.Notification;
+
+public class ValidateWorkflow : INotificationHandler<WorkflowDefinitionValidating>
+{
+    public Task HandleAsync(WorkflowDefinitionValidating notification, CancellationToken cancellationToken)
+    {
+        var workflow = notification.Workflow;
+        var inputs = workflow.Inputs;
+        var outputs = workflow.Outputs;
+
+        ValidateUniqueNames(inputs, "inputs", notification.ValidationErrors);
+        ValidateUniqueNames(outputs, "outputs", notification.ValidationErrors);
+
+        return Task.CompletedTask;
+    }
+
+    private void ValidateUniqueNames(IEnumerable<ArgumentDefinition> variables, string variableType, ICollection<WorkflowValidationError> validationErrors)
+    {
+        var duplicateNames = variables.GroupBy(x => x.Name).Where(x => x.Count() > 1).Select(x => x.Key).ToList();
+        if (duplicateNames.Any())
+        {
+            var message = $"The following {variableType} are defined more than once: {string.Join(", ", duplicateNames)}";
+            validationErrors.Add(new(message));
+        }
+    }
+}

src/modules/Elsa.Workflows.Management/Services/WorkflowValidator.cs

@@ -2,7 +2,6 @@
 using Elsa.Workflows.Activities;
 using Elsa.Workflows.Management.Models;
 using Elsa.Workflows.Management.Notifications;
-using Elsa.Workflows.Management.Requests;
 
 namespace Elsa.Workflows.Management.Services;