Skip to content

Commit

Permalink
Merge pull request #6393 from KnibbsyMan/feat/add-in-sql-editor
Browse files Browse the repository at this point in the history
Removes Built In SQL Editor Configuration
  • Loading branch information
sfmskywalker authored Feb 10, 2025
2 parents f445fbe + 23bc29e commit 08f7bd7
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using Elsa.Workflows.UIHints.CodeEditor;

// ReSharper disable once CheckNamespace
namespace Elsa.Workflows.UIHints.SqlEditor;
namespace Elsa.Sql.Activities;

internal class SqlCodeOptionsProvider : CodeEditorOptionsProviderBase
{
Expand Down
4 changes: 3 additions & 1 deletion src/modules/Elsa.Sql/Activities/SqlCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public SqlCommand([CallerFilePath] string? source = default, [CallerLineNumber]
/// </summary>
[Input(
Description = "Command to run against the database.",
UIHint = InputUIHints.SqlEditor)]
UIHint = InputUIHints.CodeEditor,
UIHandler = typeof(SqlCodeOptionsProvider)
)]
public Input<string?> Command { get; set; } = default!;


Expand Down
4 changes: 3 additions & 1 deletion src/modules/Elsa.Sql/Activities/SqlQuery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ public SqlQuery([CallerFilePath] string? source = default, [CallerLineNumber] in
/// </summary>
[Input(
Description = "Query to run against the database.",
UIHint = InputUIHints.SqlEditor)]
UIHint = InputUIHints.CodeEditor,
UIHandler = typeof(SqlCodeOptionsProvider)
)]
public Input<string?> Query { get; set; } = default!;


Expand Down
4 changes: 3 additions & 1 deletion src/modules/Elsa.Sql/Activities/SqlSingleValue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ public SqlSingleValue([CallerFilePath] string? source = default, [CallerLineNumb
/// </summary>
[Input(
Description = "Query to run against the database.",
UIHint = InputUIHints.SqlEditor)]
UIHint = InputUIHints.CodeEditor,
UIHandler = typeof(SqlCodeOptionsProvider)
)]
public Input<string?> Query { get; set; } = default!;


Expand Down
4 changes: 4 additions & 0 deletions src/modules/Elsa.Sql/Features/SqlFeature.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Elsa.Extensions;
using Elsa.Features.Abstractions;
using Elsa.Features.Services;
using Elsa.Sql.Activities;
using Elsa.Sql.Contracts;
using Elsa.Sql.Factory;
using Elsa.Sql.Implimentations;
Expand Down Expand Up @@ -51,7 +52,10 @@ public override void Apply()
})
.AddSingleton<ISqlClientFactory, SqlClientFactory>()

// Providers
.AddScoped<IPropertyUIHandler, SqlCodeOptionsProvider>()
.AddScoped<IPropertyUIHandler, SqlClientsDropDownProvider>()
.AddScoped<ISqlClientNamesProvider, SqlClientNamesProvider>();

}
}
3 changes: 0 additions & 3 deletions src/modules/Elsa.Workflows.Core/Features/WorkflowsFeature.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
using Elsa.Workflows.UIHints.CheckList;
using Elsa.Workflows.UIHints.Dropdown;
using Elsa.Workflows.UIHints.JsonEditor;
using Elsa.Workflows.UIHints.SqlEditor;
using Microsoft.Extensions.DependencyInjection;

namespace Elsa.Workflows.Features;
Expand Down Expand Up @@ -232,13 +231,11 @@ private void AddElsaCore(IServiceCollection services)
.AddScoped<IUIHintHandler, DropDownUIHintHandler>()
.AddScoped<IUIHintHandler, CheckListUIHintHandler>()
.AddScoped<IUIHintHandler, JsonEditorUIHintHandler>()
.AddScoped<IUIHintHandler, SqlEditorUIHintHandler>()

// UI property handlers.
.AddScoped<IPropertyUIHandler, StaticCheckListOptionsProvider>()
.AddScoped<IPropertyUIHandler, StaticDropDownOptionsProvider>()
.AddScoped<IPropertyUIHandler, JsonCodeOptionsProvider>()
.AddScoped<IPropertyUIHandler, SqlCodeOptionsProvider>()

// Logger state generators.
.AddSingleton(WorkflowLoggerStateGenerator)
Expand Down
1 change: 0 additions & 1 deletion src/modules/Elsa.Workflows.Core/UIHints/InputUIHints.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,5 @@ public static class InputUIHints
public const string OutputPicker = "output-picker";
public const string OutcomePicker = "outcome-picker";
public const string JsonEditor = "json-editor";
public const string SqlEditor = "sql-editor";
public const string DynamicOutcomes = "dynamic-outcomes";
}

This file was deleted.

0 comments on commit 08f7bd7

Please sign in to comment.