Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fakes for design time view model #460

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Add fakes for design time view model #460

merged 2 commits into from
Apr 21, 2022

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented Apr 20, 2022

No description provided.

@marner2 marner2 mentioned this pull request Apr 20, 2022
Closed
11 tasks
@TysonMN
Copy link
Member

TysonMN commented Apr 20, 2022

I don't like the name fake though. However, I haven't thought of a better name yet. Can you think of one?

@marner2 marner2 force-pushed the feature/add_viewmodel_fake_args branch from 14f9c8d to c3b406b Compare April 20, 2022 03:43
@LyndonGingerich
Copy link
Contributor

I don't like the name fake though. However, I haven't thought of a better name yet. Can you think of one?

Maybe sample, empty, demo, mock, or placeholder?

@TysonMN
Copy link
Member

TysonMN commented Apr 20, 2022

I thought of initial and default, but I am guessing that the latter is a keyword.

@marner2
Copy link
Collaborator Author

marner2 commented Apr 20, 2022

I like empty or none

@marner2
Copy link
Collaborator Author

marner2 commented Apr 20, 2022

@TysonMN How about ViewModelArgs.simple and LoggingViewModelArgs.none?

@TysonMN TysonMN merged commit fad8915 into elmish:master Apr 21, 2022
@TysonMN
Copy link
Member

TysonMN commented Apr 21, 2022

Yes, those are good enough names. Thanks!

@marner2 marner2 deleted the feature/add_viewmodel_fake_args branch April 21, 2022 21:19
@marner2 marner2 mentioned this pull request Apr 21, 2022
Merged
@marner2 marner2 mentioned this pull request Jun 27, 2022
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marner2 @TysonMN @LyndonGingerich