Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes code more rusty/idiomatic #264

Merged
merged 3 commits into from
Sep 11, 2021
Merged

Conversation

legendofmiracles
Copy link
Contributor

Most notable one in my opinion is the expectunwrap_or_else, the reason being that expect will always call the function - only using the result when needed (so impure)

There are stilll some clippy lints, but at the current time most of them are false positives or just wrong (they produce compiler errors when applied)

@VuiMuich
Copy link

VuiMuich commented Sep 6, 2021

There are stilll some clippy lints, but at the current time most of them are false positives or just wrong (they produce compiler errors when applied)

Might be a result of building with nightly rust, right?
So maybe reporting this to the floppy repo would be nice.

Great work on this PR btw.

@legendofmiracles
Copy link
Contributor Author

legendofmiracles commented Sep 6, 2021

Thank you, I can reproduce this with the latest nightly - but the version in the nix flake still works.
The issue was already fixed, and the latest release also contains it: rust-num/num-bigint#218.
But it seems we'll have to be waiting until the crate that depends on it, also updates its version.

EDIT: this pr fixes compilation: #265

@elkowar elkowar merged commit 634724b into elkowar:master Sep 11, 2021
@elkowar
Copy link
Owner

elkowar commented Sep 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants