8 using external file #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move AT command constants to a new conf.py file - Enhance error handling and input validation in send_at_command function - Add type hints and improve docstrings for better code readability - Implement more robust logging with formatted output - Create advanced test cases for edge cases and error scenarios - Refactor existing tests to accommodate new changes - Update default values and file naming patterns for consistency
…odule - Consolidate redundant test cases for AT commands - Enhance test coverage for animate_spinner function - Improve error handling and edge case testing - Remove commented-out test cases - Add type hints to mock objects in test functions - Use context managers for patching in some test cases - Remove unnecessary empty lines between test classes
- Add Black to the pip install command alongside flake8 - Uncomment and update the linting step to use Black for code style checking - Replace flake8 linting with Black's --check option This change enhances the CI pipeline by introducing code formatting checks, ensuring consistent code style across the project.
- Apply consistent formatting to setup.py, cli.py, usb_handle.py, and test_usb_handle.py - Improve code readability by breaking long lines and adjusting indentation - Remove unnecessary blank lines and add spacing where needed - Standardize string quotes (use double quotes consistently) - Adjust import order in some files This commit improves code consistency and adheres to PEP 8 style guidelines, making the codebase more maintainable and easier to read.
elkanamol
commented
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(sierra_status): enhance code quality, testing, and CI pipeline