fix: Use BigInt for tweet IDs in client-twitter #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweet IDs are ranging beyond JS integer support
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweet IDs are ranging beyond JS integer support
Risks
Low. Should be a straight bug fix.
What does this PR do?
Replaces the usage of
numberbybitingto store thelastCheckedTweetIdin the twitter client.What kind of change is this?
Bug fix
Why are we doing this? Any context or related work?
Tweet IDs are in the range of 2^60, which is more than Javascript can safely handle.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Running a twitter client will work but the numbers get silently rounded.
Steps:
lastCheckedTweetId.