feat: docker build character #1886
Open
+39
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odilitime
previously approved these changes
Jan 6, 2025
odilitime
approved these changes
Jan 6, 2025
HashWarlock
reviewed
Jan 6, 2025
| @@ -1,5 +1,7 @@ | |||
| # Use a specific Node.js version for better reproducibility | |||
| FROM node:23.3.0-slim AS builder | |||
| ARG CHARACTER_PATH=characters/c3po.character.json | |||
There was a problem hiding this comment.
Is it required to be defined here?
There was a problem hiding this comment.
well having a default is good, but might be able to get away with just lines 35 & 36. ill test it out
|
Should this be able to handle multiple characters to be deployed as well? |
should have no problem building multiple characters, but each |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
easier character builds for docker
Risks
low
Background
What does this PR do?
allows passing a character name in as the second arg to the docker script (also via pnpm scripts)
What kind of change is this?
QOL improvement for docker
Documentation changes needed?
updated the docker guide .md file
Testing
Detailed testing steps
pnpm docker:run <character name>Discord username
thetechnocratic