Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding workflow to check if each folder in packages/ contains __tests__ directory and README.md to maintain folder structure #1869

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ai16z-demirix
Copy link
Contributor

Relates to

#1649

Risks

Low: Adding new workflow check to check folder structure in packages directory.

Background

What does this PR do?

This PR includes workflow check: checking if every directory in packages folder containes tests and README.md

What kind of change is this?

feat

#1649

Documentation changes needed?

None

Testing

Where should a reviewer start?

github actions folder and scripts folder

Detailed testing steps

@ai16z-demirix ai16z-demirix changed the title feat: adding workflow to check if each folder in packages/ contains __tests__ directory and README.md to maintaint folder structure feat: adding workflow to check if each folder in packages/ contains __tests__ directory and README.md to maintain folder structure Jan 5, 2025
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks so much for doing this! Great work! Note this is gonna cause every PR after this one to fail this check. We shouldn't make it required until we update the existing folders under packages to have a tests folder and a readme

@shakkernerd
Copy link
Member

I have approved but will make this a draft until all packages are properly structured.

@shakkernerd shakkernerd marked this pull request as draft January 5, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants