Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dex Screener plugin with token price action, evaluators, an… #1865

Merged
merged 16 commits into from
Jan 15, 2025

Conversation

hellopleasures
Copy link
Contributor

@hellopleasures hellopleasures commented Jan 5, 2025

…d providers

Relates to

Risks

Background

What does this PR do?

Fetch token price using DexSceenerAPI

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

  • give me price of {token_name}
    11111

odilitime
odilitime previously approved these changes Jan 5, 2025
ag-wnl
ag-wnl previously approved these changes Jan 5, 2025
@cre8tions
Copy link

cre8tions commented Jan 5, 2025

agent/package.json and agent/src/index.ts leaves merge tags in the file. There seems to be minor linter issues in the files as well.

also, having the solana plugin disabled, adding this eliza gives me 2 responses to the question "whats the price of ".

agent/package.json Outdated Show resolved Hide resolved
agent/src/index.ts Outdated Show resolved Hide resolved
@hellopleasures hellopleasures reopened this Jan 6, 2025
@hellopleasures hellopleasures reopened this Jan 6, 2025
wtfsayo
wtfsayo previously approved these changes Jan 15, 2025
@wtfsayo wtfsayo self-requested a review January 15, 2025 11:30
@wtfsayo wtfsayo merged commit 6381485 into elizaOS:develop Jan 15, 2025
5 checks passed
@0xCardinalError
Copy link
Contributor

Duplicate for #1584 in name but not the functionality I was fetching there latest tokens added. Should we combine these 2 into one PR. Do I commit mine actions here or vice versa since mine PR was older? @hellopleasures

can commit here

Isnt that not possible since its his repo, I probably don't have permission to do that unless I get ma maintainer role?

fork the repo/branch or wait for merge on this one

Ok I just did this, added that code on top of current plugin, please review
#2325

@hellopleasures
Copy link
Contributor Author

sorry got busy with some stuff, thanks for everyone that review the code and for the successfully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants