Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/otel [Draft] #1853

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature/otel [Draft] #1853

wants to merge 3 commits into from
+2,110 −737

Conversation

jmikedupont2
Copy link

@jmikedupont2 jmikedupont2 commented Jan 5, 2025 •
edited
Loading

rebased and restarted, dont merge yet but a discussion point.
please ignore .env and the eliza char i will remove those

Sergey1997
Sergey1997 reviewed Jan 5, 2025
View reviewed changes
Copy link

@Sergey1997 Sergey1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, are you sure .env file should be published?

@jmikedupont2
Copy link
Author

Hey, are you sure .env file should be published?

not for everyone no, but for my debugging it is fine. this is supposed to be a beginner friendly one. i will move it to example

@ryanleecode
Copy link
Contributor

Convert to draft please :)

@jmikedupont2 jmikedupont2 changed the title Feature/otel Feature/otel [Draft] Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergey1997 Sergey1997 Sergey1997 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikedupont2 @ryanleecode @Sergey1997