Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve zkstack based plugins #1821

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

aalimsahin
Copy link
Contributor

@aalimsahin aalimsahin commented Jan 4, 2025

Relates to:

N/A (Improving zkstack plugin architecture and consistency)

Risks

Low. The changes involve refactoring and updating multiple plugins (plugin-abstract, plugin-zksync-era, plugin-cronoszkevm) to use viem for consistency.

Background

What does this PR do?

Improved environment validation for plugin-abstract, plugin-cronoszkevm, plugin-zksync-era.
Integrated viem for functionality in plugin-cronoszkevm, plugin-zksync-era for maintenance.
Added ens support to them.
Fixed issues in plugin-zksync-era and plugin-cronoszkevm where previous changes caused them to break.

What kind of change is this?

Bug fixes, Improvements and feature

Documentation changes needed?

As I check, no need

Testing

Where should a reviewer start?

Almost all plugins are the same, so you can choose one. After that, others will be the same.

Detailed testing steps

Initialize plugins in character.
You can choose to test one of them.
Add envs for the plugin. Try the wrong env to test env validation.
Start one client to check it. You can say to agent like send x amount eth to y address(or ens) in z chain

NOTE

Fixed the overflow problem in chat. You can check last image.

Screenshot 2025-01-04 at 20 55 09 Screenshot 2025-01-04 at 16 50 12 Screenshot 2025-01-04 at 21 01 24

Discord username

aalimsahin

@aalimsahin aalimsahin changed the title Refactor/zkstack plugins feat: improve zkstack based plugins Jan 4, 2025
@wtfsayo wtfsayo self-requested a review January 6, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants