Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nimble options for converter and reader #30

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

gBillal
Copy link
Collaborator

@gBillal gBillal commented Jan 27, 2025

No description provided.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (c43f710) to head (17d45d6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   87.91%   88.09%   +0.18%     
==========================================
  Files           6        6              
  Lines          91       84       -7     
==========================================
- Hits           80       74       -6     
+ Misses         11       10       -1     
Files with missing lines Coverage Δ
lib/encoder.ex 100.00% <ø> (ø)
lib/reader.ex 91.42% <100.00%> (-0.24%) ⬇️
lib/video_converter.ex 90.90% <100.00%> (+2.67%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43f710...17d45d6. Read the comment docs.

@gBillal gBillal merged commit 029ee0d into master Jan 27, 2025
7 checks passed
@gBillal gBillal deleted the use-nimble-options branch January 27, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant