Add h26x decoder support #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released as 0.8.0 :) |
|
Btw @gBillal, how did you generate h264 and h265 frames? It would be nice to write this down somewhere :P |
|
For that I just grabbed the first sample from a valid mp4 file (the famous BigBuck). An easier way to do that is to use ffmpeg # h264
ffmpeg -i your_mp4_file.mp4 -c:v copy -vframes 1 -f h264 sample.h264
# h265
ffmpeg -i your_mp4_file.mp4 -c:v copy -vframes 1 -f hevc sample.h265I may add this commands as comment to the tests |
|
@gBillal Would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for creating this project. I have always wanted something to use for decoding videos without the need to rely on membrane pipelines.
In this PR, I added support for
h264/h265decoders. Unlikevp8where there's no notion of B frames and to not change the public API of the decoder since the decoder can return multiple frames at the same time, I added aflush/1function to signals end of stream and get the buffered frames in the decoder.