Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: docs housekeeping #740

Merged
merged 1 commit into from
Dec 27, 2024
Merged

docs: docs housekeeping #740

merged 1 commit into from
Dec 27, 2024

Conversation

kianmeng
Copy link
Contributor

List of changes:

  • add changelog link to module info page
  • add title to license page
  • link changelog to releases page

@yordis
Copy link
Member

yordis commented Dec 27, 2024

Thank you so much! CI is failing btw it seems you need to run the formatter

yordis
yordis reviewed Dec 27, 2024
View reviewed changes
mix.exs Outdated
links: %{"GitHub" => "https://github.com/elixir-tesla/tesla"}
links: %{
"GitHub" => @source_url,
"Changelog" => "#{@source_url}/releases"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #728 is merged, we will have a CHANGELOG file

yordis
yordis reviewed Dec 27, 2024
View reviewed changes
mix.exs Outdated
Comment on lines 105 to 106
# TODO: add CHANGELOG.md
# "CHANGELOG.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need this changelog after #728

@kianmeng kianmeng requested a review from yordis December 27, 2024 20:18
@kianmeng
docs: docs housekeeping
90d5463 
List of changes:
- add changelog link to module info page
- add title to license page
@yordis yordis merged commit bdb02aa into elixir-tesla:master Dec 27, 2024
6 checks passed
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

@yordis
Copy link
Member

yordis commented Dec 29, 2024

(correction, it is much, and deeply appreciated) you always remind me this meme

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis yordis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kianmeng @yordis