Resolve Dialyzer errors on Elixir 1.16

[nathany-copia]

closes #642

This is to address this Dialyzer error seen in Elixir 1.16.

Total errors: 3, Skipped: 0, Unnecessary Skips: 0
done in 0m1.17s
lib/tesla/multipart.ex:94: Function add_file/2 has no local return
lib/tesla/multipart.ex:94: Function add_file/3 has no local return
lib/tesla/multipart.ex:106: The call 'Elixir.File':'stream!'(_path@1::binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | char(),binary() | []),[],2048) breaks the contract ('Elixir.Path':t(),'line' | pos_integer(),[stream_mode()]) -> 'Elixir.File.Stream':t()
done (warnings were emitted)
Halting VM with exit status 2

Dialyzer is also added to CI as a separate job (it can be rather slow, and we may want to control success/failure independently for Dialyzer)

[nathany-copia]

FYI, I'm seeing a number of test failures (8) locally -- on the master branch as well.

[nathany-copia]

@yordis Are there any other changes needed before we can merge this and publish a Tesla release that supports Elixir 1.16?

[yordis]

We need to add OTP 26 to the CI pipeline to make sure it is green

[nathany-copia]

CI updated.

I don't think we need any matrix exceptions based on the versions I saw over here, but I'm happy to make other changes.
https://github.com/ex-aws/ex_aws_s3/pull/239/files

Thanks.

[peaceful-james]

I am looking forward to this being merged :)

[nathany-copia]

Merged in master.

[yordis]

@nathany-copia could you use #623 as the baseline? Really appreciate your support here.

Related to edgurgel/httparrot#38

The fix is in httparrot if I am not mistaken

[nathany-copia]

@yordis With Dialyzer passing on all Elixir versions, I hope we can review and merge this even without the httparrot issues fixed, as that would allow us to stop using a fork of Tesla.

[nathany-copia]

Please let me know if you'd like any other changes.

Thanks!

[yordis]

Really appreciate your support, thank you so much 🚀 💜

[yordis]

Hopefully we can figure out the elixir 1.6+ situation next 😭

[nathany-copia]

Hopefully we can figure out the elixir 1.6+ situation next 😭

Absolutely. I already opened a pull request to httparrot, so we'll see how that goes.

@yordis We'd appreciate another hex release if you don't mind. ❤️

@peaceful-james I'll leave this branch here for a bit, just in case you're using it.

[peaceful-james]

@nathany-copia I am not using it but thank you.