Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset stmt when done #305

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Oct 14, 2024

Handles #298 (comment)

[...] In the future, it should be called once we are done with the statement rather than before using it since otherwise SQLite would be wasting resources by keeping finished but non-reset statements.

It also improves bind/2 performance since it doesn't have to go through dirty scheduler for a reset/1 call anymore.

@warmwaffles warmwaffles merged commit 81cf923 into elixir-sqlite:main Oct 23, 2024
8 of 9 checks passed
@ruslandoga ruslandoga deleted the reset-when-done branch October 23, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants