Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a String or charstring for database open #290

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

warmwaffles
Copy link
Member

Closes #278
Closes #277

@warmwaffles
Copy link
Member Author

For some stupid reason, locally my system is failing for

  1) test .connect/1 fails to write a file from URL with mode=ro (Exqlite.ConnectionTest)
     test/exqlite/connection_test.exs:59
     ** (MatchError) no match of right hand side value: {:error, %Exqlite.Error{message: "database_open_failed", statement: nil}}
     code: {:ok, conn} = Connection.connect(database: "file:#{path}?mode=ro")
     stacktrace:
       test/exqlite/connection_test.exs:72: (test)
  2) test .connect/1 connects to a file from URL (Exqlite.ConnectionTest)
     test/exqlite/connection_test.exs:50
     ** (MatchError) no match of right hand side value: {:error, %Exqlite.Error{message: "database_open_failed", statement: nil}}
     code: {:ok, state} = Connection.connect(database: "file:#{path}?mode=rwc")
     stacktrace:
       test/exqlite/connection_test.exs:53: (test)

I need to figure out why.

@warmwaffles warmwaffles merged commit d39a700 into main Sep 13, 2024
13 of 15 checks passed
@warmwaffles warmwaffles deleted the fix-allow-binary-to-be-passed branch September 13, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug opening a database with an accent in path
1 participant