Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop utf8.h #264

Merged
merged 1 commit into from
Oct 12, 2023
Merged

drop utf8.h #264

merged 1 commit into from
Oct 12, 2023

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Oct 12, 2023 •
edited
Loading

as proposed in #258 (comment)

ruslandoga
ruslandoga commented Oct 12, 2023
View reviewed changes
Makefile

CFLAGS = -I"$(ERTS_INCLUDE_DIR)"

ifeq ($(EXQLITE_USE_SYSTEM),)
SRC += c_src/sqlite3.c
HEADERS += c_src/sqlite3.h c_src/sqlite3ext.h
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like HEADERS were unused.

warmwaffles
warmwaffles approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@warmwaffles warmwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests as well.

@warmwaffles warmwaffles merged commit 9708b12 into elixir-sqlite:main Oct 12, 2023
@ruslandoga ruslandoga deleted the drop-utf8 branch October 12, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmwaffles warmwaffles warmwaffles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @warmwaffles