added precompilation support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this is awesome. I was never able to find time to do this. 🙌🏻 thanks! |
warmwaffles
approved these changes
Feb 20, 2023
|
@cocoa-xu released under |
No worries! Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds precompilation support for exqlite, and it still allows the user to set their advanced configurations, https://github.com/elixir-sqlite/exqlite#advanced-configuration.
I also have a working one on my fork, and here is the log of the precompilation workflow, https://github.com/cocoa-xu/exqlite/actions/runs/4210648732 and all the precompiled binaries, https://github.com/cocoa-xu/exqlite/releases/tag/v0.13.2.
It should address all the concerns in #230, but if not, please let me know, and I'll be happy to help!