Migrating static nif code for OTP25 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using this change for https://github.com/elixir-desktop/ios-example-app - which packages exqlite to run on iOS. This now runs on stock OTP25 vs. previously only on a custom branch of OTP24 |
|
This looks good. Tests pass so I assume it's backwards compatible to OTP23. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OTP25 the Erlang team has introduced an official macro to support Elixir statically linked nifs
STATIC_ERLANG_NIF_LIBNAME. This commit switches the compilation unit to useSTATIC_ERLANG_NIF_LIBNAMEinstead of the previous macro override hack.