Support mkdir -p behavior when DB file does not exist #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can't this be solved at the elixir level? I'd rather stay away from modifying |
|
@warmwaffles You're totally right - In fact, @fhunleth and I were just talking about this. I just jumped the gun to C for who-knows-why 🤦 Sit tight - Better change coming up soon |
|
@jjcarstens it's not a big deal, I admire the effort to dig into the sqlite3.c file. That thing is a pain to load in the text editor. |
Currently, if you supply a DB path that includes directories which do not exist, sqlite3 will not attempt to create them and the open will crash. This adds a quick attempt to `mkdir` on the db path to ensure all intermediary directories exist before attempting to create the DB file for cases that `SQLITE_OPEN_CREATE` flag is enabled and would expect the file to be created when non-existant
|
Ok @warmwaffles - Much easier in Elixir 🤣 |
|
Much cleaner too! |
|
So fast! Thanks @warmwaffles ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you supply a DB path that includes directories which do not exist, sqlite3 will not attempt to create them and the open will crash.
This adds a quick attempt to
mkdiron the db path to ensure all intermediary directories exist before attempting to create the DB file for cases thatSQLITE_OPEN_CREATEflag is enabled and would expect the file to be created when non-existant