-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tabset corners; rework border-radius across styles #2077
Improve tabset corners; rework border-radius across styles #2077
Conversation
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/13014732279/artifacts/2498536953 |
I'd propose for admonitions to be either:
Regarding functions, I don't think they should have radius. The border with radius don't work well IMO. :) |
Maybe we make them 'outer' when not nested, and something between 'outer' and 'inner' when they are inner? This might be a reasonable way of maintaining their current feel while still moving them toward optical radius consistency when they're inner. I'll give that a go and post some screenshots.
Okay, I'll revert. Thanks. |
After a little experimentation, it seems to me that a good approach would be to simply use an in-between radius for all admonitions. (Currently 8px.) This allows all admonition boxes, regardless of context, to maintain a more rounded feel relative to the code boxes, which I think helps differentiate them. (Not everything has to be the same.) Deviation of border radius for admonitions due to being in a tabset would likely feel slightly jarring as their coloured top bars would emphasise the difference. Code boxes are still 3px, which is just rounded enough to nicely soften the corners. Tabset boxes are 14px, for the "concentric" consideration. Callback/function headings border radius has been removed. I've compared with how it is in main again (all with the same radius), and I feel that having three radii used consistently, with a view to the concentric effect of the corners, gives a better feel on balance. And I've realised that I like the code boxes having a far more modest radius than the admonition boxes, which somehow feels a little stronger/refined(?). It's not that it's objectively good or bad either way in this respect - just that one pro of this approach is greater differentiation between the two different kinds of elements. |
Sounds good to me! |
Do you like the way using the three radii looks? If so, and you're happy to proceed, I'll check everywhere else border radius is used and select the most appropriate of the three custom properties. |
Yes, if you are happy, I am happy! Feel free to merge and please let me know once you think we are ready for the final release. :) |
I believe all border radiuses are now properly set, given the new approach, but it would be great if you get a chance to have a quick test, too. When choosing one of the three options for each element, I've tended to match/choose the closest to the last release's radius values. I'm now doubting the use of inner, middle and outer for custom property names as there's only one place this scheme is actually used in that way - in the tabsets. Shall I rename to sm, md and lg or similar? |
Sounds good to me! |
I went over the changes and they look good to me. Honestly, I don't have a strong opinion on this matter, as long as we have a proper mental model to move forward, I am happy. :) |
Okay, thanks. For simplicity for others who may make edits without seeing the reason for the naming scheme, I'll convert to plain size names. |
One reason for this suggestion is avoiding the optical mismatch between inner and outer frames:
This introduces an inner radius and an outer radius:
Summary:
This also introduces the inner/small radius to callback/function headings:Draft status as there are likely more outers to change to inners. I'll wait to hear whether or not this approach is desired.