Add dot_iex IEx.Config key to take precedence over existing configurations
#13647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jun 9, 2024
josevalim
reviewed
Jun 9, 2024
josevalim
reviewed
Jun 9, 2024
|
💚 💙 💜 💛 ❤️ |
fhunleth
added a commit
to nerves-project/nerves_ssh
that referenced
this pull request
Jan 6, 2025
The `:dot_iex_path` option changed to `:dot_iex` in Elixir 1.18. Since NervesSSH was using the old option name, running the `iex.exs` file when logging in stopped working. This adds support for the new option name in Elixir 1.18 and normalizes whatever the users passes in to work right on the version of Elixir that they're using. See elixir-lang/elixir#13647 for the links and discussion about this update.
fhunleth
added a commit
to nerves-project/nerves_ssh
that referenced
this pull request
Jan 6, 2025
The `:dot_iex_path` option changed to `:dot_iex` in Elixir 1.18. Since NervesSSH was using the old option name, running the `iex.exs` file when logging in stopped working. This adds support for the new option name in Elixir 1.18 and normalizes whatever the users passes in to work right on the version of Elixir that they're using. See elixir-lang/elixir#13647 for the links and discussion about this update.
fhunleth
added a commit
to nerves-project/nerves_ssh
that referenced
this pull request
Jan 6, 2025
The `:dot_iex_path` option changed to `:dot_iex` in Elixir 1.18. Since NervesSSH was using the old option name, running the `iex.exs` file when logging in stopped working. This adds support for the new option name in Elixir 1.18 and normalizes whatever the users passes in to work right on the version of Elixir that they're using. See elixir-lang/elixir#13647 for the links and discussion about this update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the google group this PR adds a
dot_iexconfig option to the iex application for dot-iex path configurationLet me know if there are any changes you would like to see!