Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nested expectations #54

Closed
wants to merge 1 commit into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Apr 23, 2015

A nested expectation adds unnecessary complexity.

Additionally, this spec was stubbing the system under test (Subscription):
https://robots.thoughtbot.com/don-t-stub-the-system-under-test

A nested expectation adds unnecessary complexity.

Additionally, this spec was stubbing the system under test (Subscription):
https://robots.thoughtbot.com/don-t-stub-the-system-under-test
@eliotsykes
Copy link
Owner

Thanks @andyw8. Where is the stub being tested rather than the system, I'm not seeing it, though acknowledge it could be the case.

@andyw8
Copy link
Contributor Author

andyw8 commented Apr 23, 2015

You're correct, I misread it. But I still think it's good to avoid nesting them.

@eliotsykes
Copy link
Owner

@andyw8 apologies for the delay in looking at these, taking a look now...

@eliotsykes
Copy link
Owner

Merged

@eliotsykes
Copy link
Owner

202fdb3

@eliotsykes eliotsykes closed this Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants