IE8 8.0.6001.18702 workaround #43
Conversation
adding undefined to fight this issue #36 modernie IE8-MSW7 machine has IE8 8.0.6001.18702 and is affected
| @@ -173,7 +173,9 @@ if (objCtr.defineProperty) { | |||
| try { | |||
| objCtr.defineProperty(elemCtrProto, classListProp, classListPropDesc); | |||
| } catch (ex) { // IE 8 doesn't support enumerable:true | |||
| if (ex.number === -0x7FF5EC54) { | |||
| // adding undefined to fight this issue https://github.com/eligrey/classList.js/issues/36 | |||
| // modernie IE8-MSW7 machine has IE8 8.0.6001.18702 and is affected | |||
There was a problem hiding this comment.
modernie = http://www.modern.ie/ = webpage, where MS hosts free virtual machines, so one can test webcode on OSses from MSWXP up to MSW10, IE6 up to IE11 & Edge. the page now gets redirected to https://developer.microsoft.com/en-us/microsoft-edge/ (this is more than one year old pull request 😄 ) and the actual page now for virtual machines is https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ where the lowest now is WinXP w/ IE8. Thus the comment reads "modern.ie IE8-MSW7 virtual machine has IE8 8.0.6001.18702 and is affected". We test all old IE versions in virtual machines, and those provided by MS are a legal way to do so.
it is hard to comment on what happens now, in times of ES7 and Babel and thus different way to polyfill everything, we do not use these separate polyfills/shims directly any more including this one.
There was a problem hiding this comment.
My bad, I thought it was a typo. Good to know regarding modern.ie. I still use this polyfill as a standalone polyfill but I'm probably an exception :)
There was a problem hiding this comment.
Yeah. it was about the MS virtual images distributed by modernie (WHICH IS NOW https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/) where devs can download images to test for old ie's
adding undefined to fight this issue #36
modernie IE8-MSWXP machine has IE8 8.0.6001.18702 and is affected