import person roles #114
import person roles #114
Conversation
| @@ -690,7 +695,7 @@ def main(): | |||
|
|
|||
| process_files_in_directory_or_zip(source, process_zip, ext=".zip") | |||
|
|
|||
| logging.getLogger(NAME).info("done") | |||
| get_logger().info("done") | |||
There was a problem hiding this comment.
Would normally just define the logger at the top of the file and use that constant throughout that module scope.
LOGGER = logging.getLogger(__name__)
It is a more common pattern, but preferences aside, also reduces multiple calls to logging.getLogger(__name__).
There was a problem hiding this comment.
At the module level? Wouldn't that cause issues with the logging configuration? Something like the logger being initialised the first time getLogger is called. I'm sure I observed something which made me change to this pattern (after consulting 'the internet'). Although I couldn't replicate it now so not sure what it was.
There was a problem hiding this comment.
I raised a separate issue for that: #117
There was a problem hiding this comment.
When you call logging.getLogger(__name__) in this module, it is returning back a reference to the same logger object every time (the one created for importDataToDatabase in this case) regardless to when you call it.
There was a problem hiding this comment.
Ah ok just seen you comment regarding #117 👍
Pre-requisite for #113
This will import the person roles from the eJP XML dumps (it won't use it yet).
(This may actually be deactivated again at some point because we are planning to have a more complte CSV export with that information as well)