Skip to content
This repository has been archived by the owner on Jun 1, 2020. It is now read-only.

Osx makefile #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Osx makefile #11

wants to merge 3 commits into from

Conversation

aherlihy
Copy link

Hi,

I modified the makefile so that it compiles on Darwin. I've put each change in a separate commit in case you would like to separate them.

The only issue I haven't been able to resolve is the ArgumentsAdjuster API change. If you have the time, I would appreciate any input you might have.

Thank you!

@eliben
Copy link
Owner

eliben commented Nov 14, 2014

Thanks, @aherlihy

I'll have to think a bit whether I want this in the Makefile, or just to point folks to this pull request if they ask about Darwin.

@unphased
Copy link

I just tested this on Centos 7 Linux (master branch and llvm/clang checked out at r224244) and linking succeeds with the change of removing -Wl,--{start,end}-group and adding -Wl,-undefined,dynamic_lookup to the $(PLUGIN_LDFLAGS).

This indicates to me that it is a better way to write the makefile since it would then work out of the box (and without any makefile environment switch) in both linux and OS X.

@tbg
Copy link

tbg commented Nov 24, 2017

Confirmed that this worked for me on OSX at 5.0 with only the line PLUGIN_LDFLAGS := -shared -Wl,-undefined,dynamic_lookup (I didn't build the clang-stuff though, only the pure llvm).

Thanks @aherlihy!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants